tools/dom/scripts/systemhtml.py - Issue 142563006: Make the Dart code generators handle the Image constructor specified in the IDL without crashing or…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemhtml.py

Issue 142563006: Make the Dart code generators handle the Image constructor specified in the IDL without crashing or… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/systemhtml.py

diff --git a/tools/dom/scripts/systemhtml.py b/tools/dom/scripts/systemhtml.py

index c5c0434515d9114e4c40ca5bfb885292ccca8036..54ad00d318651af9c6ed565cc49d63baab7f9907 100644

--- a/tools/dom/scripts/systemhtml.py

+++ b/tools/dom/scripts/systemhtml.py

@@ -512,10 +512,10 @@ class HtmlDartInterfaceGenerator(object):

for info in infos:

constructors.append(info.ConstructorInfo(self._interface.id))

- if factory_provider:

- assert factory_provider == info.factory_provider_name

- else:

- factory_provider = info.factory_provider_name

+ if factory_provider and factory_provider != info.factory_provider_name:

+ _logger.warn('Conflicting factory provider names: %s != %s' %

+ (factory_provider, info.factory_provider_name))

+ factory_provider = info.factory_provider_name

implementation_emitter = self._ImplementationEmitter()

« no previous file with comments | « tools/dom/scripts/htmldartgenerator.py ('k') | no next file » | no next file with comments »