tools/dom/scripts/htmldartgenerator.py - Issue 142563006: Make the Dart code generators handle the Image constructor specified in the IDL without crashing or…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 142563006: Make the Dart code generators handle the Image constructor specified in the IDL without crashing or… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/dom/scripts/htmldartgenerator.py

diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py

index d549d981154a9873480fb08c25e0c4f30d76cc3a..5701cc81868ad0747fd789eed5b2a236703e74b3 100644

--- a/tools/dom/scripts/htmldartgenerator.py

+++ b/tools/dom/scripts/htmldartgenerator.py

@@ -477,6 +477,11 @@ class HtmlDartGenerator(object):

def _AddConstructor(self,

constructor_info, factory_name, factory_constructor_name):

+ # Hack to ignore the Image constructor used by JavaScript.

+ if (self._interface.id == 'HTMLImageElement'

+ and not constructor_info.pure_dart_constructor):

+ return

if self.GenerateCustomFactory(constructor_info):

return

« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/scripts/systemhtml.py » ('j') | no next file with comments »