Issue 142563002: Fix compilation with latest Xcode toolchain.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 142563002: Fix compilation with latest Xcode toolchain. (Closed)

Created:
6 years, 11 months ago by Benedikt Meurer

Modified:
6 years, 11 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix compilation with latest Xcode toolchain. TBR=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18673

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	src/ia32/lithium-ia32.h	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

Committed patchset #1 manually as r18673 (presubmit successful).

6 years, 11 months ago (2014-01-19 12:24:32 UTC) #1

Jarin

On 2014/01/19 12:24:32, Benedikt Meurer wrote: > Committed patchset #1 manually as r18673 (presubmit successful). ...

6 years, 11 months ago (2014-01-19 23:50:24 UTC) #2

hv1989

On 2014/01/19 23:50:24, jarin wrote: > On 2014/01/19 12:24:32, Benedikt Meurer wrote: > > Committed ...

6 years, 11 months ago (2014-01-20 16:49:57 UTC) #3

mathias

6 years, 11 months ago (2014-01-21 15:26:58 UTC) #4

Message was sent while issue was closed.

On 2014/01/20 16:49:57, hv1989 wrote:
> On 2014/01/19 23:50:24, jarin wrote:
> > On 2014/01/19 12:24:32, Benedikt Meurer wrote:
> > > Committed patchset #1 manually as r18673 (presubmit successful).
> > 
> > lgtm. thanks for the cleanup.
> 
> Could it be this need to be done for x64 too? Arewefastyet started running v8
> again on x86 after this fix, but it is still not running for x64 ...

Patch: https://codereview.chromium.org/143003007

Expand Messages | Collapse Messages