Fix compilation on x64 architectures

Fix compilation on x64 architectures

Contributed by Mathias Bynens <mathiasb@opera.com>;.

BUG=v8:3110
LOG=Y
R=bmeurer@chromium.org, jarin@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18760

[Jarin, 2014-01-22 03:01:34]

lgtm

[tfarina, 2014-01-23 02:39:47]

Benedikt, Jarin, can either of you land this CL for Mathias?

I'm also hitting this compile failure:

$ ninja -C out/Debug/ d8
ninja: Entering directory `out/Debug/'
[145/170] CXX obj/src/x64/v8_base.x64.lithium-x64.o
FAILED: clang++ -MMD -MF obj/src/x64/v8_base.x64.lithium-x64.o.d
-DV8_TARGET_ARCH_X64 -DENABLE_DEBUGGER_SUPPORT -DENABLE_GDB_JIT_INTERFACE
-DV8_DEPRECATION_WARNINGS -DV8_I18N_SUPPORT -DV8_USE_DEFAULT_PLATFORM
-DBUILDING_V8_SHARED -DV8_SHARED -DU_USING_ICU_NAMESPACE=0 -DENABLE_DISASSEMBLER
-DV8_ENABLE_CHECKS -DOBJECT_PRINT -DVERIFY_HEAP -DDEBUG -DENABLE_EXTRA_CHECKS
-DENABLE_HANDLE_ZAPPING -I../../src -I../../third_party/icu/source/i18n
-I../../third_party/icu/source/common -Wall -Werror -W -Wno-unused-parameter
-pthread -fno-exceptions -pedantic -ansi -fvisibility=hidden -fPIC -m64 -m64 -g
-Wall -Werror -W -Wno-unused-parameter -Wnon-virtual-dtor -Woverloaded-virtual 
-fdata-sections -ffunction-sections -Wall -Werror -W -Wno-unused-parameter
-Wnon-virtual-dtor -Woverloaded-virtual -fdata-sections -ffunction-sections
-Wnon-virtual-dtor -fno-rtti  -c ../../src/x64/lithium-x64.cc -o
obj/src/x64/v8_base.x64.lithium-x64.o
In file included from ../../src/x64/lithium-x64.cc:32:
In file included from ../../src/lithium-allocator-inl.h:36:
../../src/x64/lithium-x64.h:1810:34: error: private field 'descriptor_' is not
used [-Werror,-Wunused-private-field]
  const CallInterfaceDescriptor* descriptor_;
                                 ^
1 error generated.

[Jarin, 2014-01-23 03:10:25]

lgtm

(the issue appears to be reopened, could not commit)

[Jarin, 2014-01-23 03:15:25]

On 2014/01/23 03:10:25, jarin wrote:
> lgtm
> 
> (the issue appears to be reopened, could not commit)

Hmm, I am still having trouble committing the patch for some reason I do not
understand:

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    src/x64/lithium-x64.h

[Benedikt Meurer, 2014-01-23 06:23:45]

LGTM, I'll land it.

[Benedikt Meurer, 2014-01-23 06:31:13]

Committed patchset #1 manually as r18760 (presubmit successful).

[mathias, 2014-01-23 08:58:21]

Sorry, I forgot to add an entry in AUTHORS. Fixed here:
https://codereview.chromium.org/135493003

[tfarina, 2014-01-23 15:03:35]

On 2014/01/23 03:15:25, jarin wrote:
> On 2014/01/23 03:10:25, jarin wrote:
> > lgtm
> > 
> > (the issue appears to be reopened, could not commit)
> 
> Hmm, I am still having trouble committing the patch for some reason I do not
> understand:
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
>     src/x64/lithium-x64.h

I think you need to contact someone from the Infra to make sure you are in the
internal list for the commit-queue (maruel, rmistry). Otherwise, it is strange,
because you are listed as OWNER in
https://code.google.com/p/v8/source/browse/branches/bleeding_edge/OWNERS#7

[mathias, 2014-01-23 15:09:32]

On 2014/01/23 15:03:35, tfarina wrote:
> [jarin] [is] listed as OWNER in
> https://code.google.com/p/v8/source/browse/branches/bleeding_edge/OWNERS#7

jarin was added to OWNERS in the next revision:
https://code.google.com/p/v8/source/detail?r=18761