Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1425603002: MIPS64: Fix r6 boolean materializations after a float32 compare. (Closed)

Created:
5 years, 1 month ago by paul.l...
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix r6 boolean materializations after a float32 compare. The upper 32-bits of the FP compare register are undefined in the float32 case. The compare instruction returns all 1's or all 0's, so just use the LS bit. Remove unnecessary use of 'at' reg. Change mips32 for consistency, but it did not have the bug. TEST=mjsunit/asm/embenchen/box2d (r6) BUG= Committed: https://crrev.com/efa752d98b471981b9bef99334cc6921f23efcf2 Cr-Commit-Position: refs/heads/master@{#31582}

Patch Set 1 #

Patch Set 2 : mips32 change, for consistency (no bug on mips32r6) #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +4 lines, -3 lines 1 comment Download

Messages

Total messages: 13 (7 generated)
ivica.bogosavljevic
https://codereview.chromium.org/1425603002/diff/20001/src/compiler/mips64/code-generator-mips64.cc File src/compiler/mips64/code-generator-mips64.cc (right): https://codereview.chromium.org/1425603002/diff/20001/src/compiler/mips64/code-generator-mips64.cc#newcode1184 src/compiler/mips64/code-generator-mips64.cc:1184: __ andi(result, result, 1); // Cmp returns all 1's/0's, ...
5 years, 1 month ago (2015-10-26 09:45:51 UTC) #2
Ilija.Pavlovic1
lgtm
5 years, 1 month ago (2015-10-26 12:04:51 UTC) #4
akos.palfi.imgtec
LGTM.
5 years, 1 month ago (2015-10-26 16:27:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425603002/20001
5 years, 1 month ago (2015-10-26 16:35:28 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-26 17:46:40 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 17:47:00 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/efa752d98b471981b9bef99334cc6921f23efcf2
Cr-Commit-Position: refs/heads/master@{#31582}

Powered by Google App Engine
This is Rietveld 408576698