Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: src/compiler/mips64/code-generator-mips64.cc

Issue 1425603002: MIPS64: Fix r6 boolean materializations after a float32 compare. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: mips32 change, for consistency (no bug on mips32r6) Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/mips/code-generator-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/code-generator.h" 5 #include "src/compiler/code-generator.h"
6 #include "src/compiler/code-generator-impl.h" 6 #include "src/compiler/code-generator-impl.h"
7 #include "src/compiler/gap-resolver.h" 7 #include "src/compiler/gap-resolver.h"
8 #include "src/compiler/node-matchers.h" 8 #include "src/compiler/node-matchers.h"
9 #include "src/compiler/osr.h" 9 #include "src/compiler/osr.h"
10 #include "src/mips/macro-assembler-mips.h" 10 #include "src/mips/macro-assembler-mips.h"
(...skipping 1162 matching lines...) Expand 10 before | Expand all | Expand 10 after
1173 } else { 1173 } else {
1174 __ Movt(result, zero_reg); 1174 __ Movt(result, zero_reg);
1175 } 1175 }
1176 } else { 1176 } else {
1177 if (instr->arch_opcode() == kMips64CmpD) { 1177 if (instr->arch_opcode() == kMips64CmpD) {
1178 __ cmp(cc, L, kDoubleCompareReg, left, right); 1178 __ cmp(cc, L, kDoubleCompareReg, left, right);
1179 } else { 1179 } else {
1180 DCHECK(instr->arch_opcode() == kMips64CmpS); 1180 DCHECK(instr->arch_opcode() == kMips64CmpS);
1181 __ cmp(cc, W, kDoubleCompareReg, left, right); 1181 __ cmp(cc, W, kDoubleCompareReg, left, right);
1182 } 1182 }
1183 __ dmfc1(at, kDoubleCompareReg); 1183 __ dmfc1(result, kDoubleCompareReg);
1184 __ dsrl32(result, at, 31); // Cmp returns all 1s for true. 1184 __ andi(result, result, 1); // Cmp returns all 1's/0's, use only LSB.
ivica.bogosavljevic 2015/10/26 09:45:51 That's the thing we need :)
1185 if (!predicate) // Toggle result for not equal. 1185
1186 if (!predicate) // Toggle result for not equal.
1186 __ xori(result, result, 1); 1187 __ xori(result, result, 1);
1187 } 1188 }
1188 return; 1189 return;
1189 } else { 1190 } else {
1190 PrintF("AssembleArchBranch Unimplemented arch_opcode is : %d\n", 1191 PrintF("AssembleArchBranch Unimplemented arch_opcode is : %d\n",
1191 instr->arch_opcode()); 1192 instr->arch_opcode());
1192 TRACE_UNIMPL(); 1193 TRACE_UNIMPL();
1193 UNIMPLEMENTED(); 1194 UNIMPLEMENTED();
1194 } 1195 }
1195 } 1196 }
(...skipping 345 matching lines...) Expand 10 before | Expand all | Expand 10 after
1541 padding_size -= v8::internal::Assembler::kInstrSize; 1542 padding_size -= v8::internal::Assembler::kInstrSize;
1542 } 1543 }
1543 } 1544 }
1544 } 1545 }
1545 1546
1546 #undef __ 1547 #undef __
1547 1548
1548 } // namespace compiler 1549 } // namespace compiler
1549 } // namespace internal 1550 } // namespace internal
1550 } // namespace v8 1551 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/mips/code-generator-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698