Issue 14256007: drive: Remove polling code from DriveFileSystem

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14256007: drive: Remove polling code from DriveFileSystem (Closed)

Created:
7 years, 8 months ago by satorux1

Modified:
7 years, 8 months ago

Reviewers:
kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Remove polling code from DriveFileSystem The XMPP-based notification seems to be reliable enough that we don't have to maintain the polling code. Shouldn't be difficult to add this back if needed. BUG=231202 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194294

Patch Set 1 #

Patch Set 2 : fix #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -47 lines)			Patch
M	chrome/browser/chromeos/drive/drive_file_system.h	View		3 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_file_system.cc	View		4 chunks	+0 lines, -29 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_file_system_metadata.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/drive/drive_file_system_metadata.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/resources/chromeos/drive_internals.html	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/drive_internals_ui.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

7 years, 8 months ago (2013-04-16 04:46:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r194294 (presubmit successful).

Expand Messages | Collapse Messages