base/metrics/histogram_delta_serialization.h - Issue 1425533011: Support "shared" histograms between processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_delta_serialization.h

Issue 1425533011: Support "shared" histograms between processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc

Patch Set: reorganized persistence around PersistentGet methods to fix visibility problems Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/histogram_delta_serialization.h

diff --git a/base/metrics/histogram_delta_serialization.h b/base/metrics/histogram_delta_serialization.h

index 0a3983f8eabb8fedb0a2a1be666ae323f294fa89..fba5bec4950c2174e3a67163be3e60646865ef5c 100644

--- a/base/metrics/histogram_delta_serialization.h

+++ b/base/metrics/histogram_delta_serialization.h

@@ -30,7 +30,8 @@ class BASE_EXPORT HistogramDeltaSerialization : public HistogramFlattener {

// this method. Stores the deltas in serialized form into |serialized_deltas|.

// If |serialized_deltas| is NULL, no data is serialized, though the next call

// will compute the deltas relative to this one.

- void PrepareAndSerializeDeltas(std::vector<std::string>* serialized_deltas);

+ void PrepareAndSerializeDeltas(std::vector<std::string>* serialized_deltas,

+ bool include_persistent);

Alexei Svitkine (slow) 2016/01/12 21:54:44 Document the new param.

bcwhite 2016/01/13 13:38:29 Done.

// Deserialize deltas and add samples to corresponding histograms, creating

// them if necessary. Silently ignores errors in |serialized_deltas|.

« base/metrics/histogram_base.cc ('K') | « base/metrics/histogram_base.cc ('k') | base/metrics/histogram_delta_serialization.cc » ('j') | base/metrics/histogram_persistence.h » ('J')