base/metrics/histogram_base.cc - Issue 1425533011: Support "shared" histograms between processes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/metrics/histogram_base.cc

Issue 1425533011: Support "shared" histograms between processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shmem-alloc

Patch Set: reorganized persistence around PersistentGet methods to fix visibility problems Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/metrics/histogram_base.cc

diff --git a/base/metrics/histogram_base.cc b/base/metrics/histogram_base.cc

index 412f1438d2fbde0b04a35c863dcba8b0e8e954dc..1bfe633a43aa4c08594bda2ca64902f4b9f6e52d 100644

--- a/base/metrics/histogram_base.cc

+++ b/base/metrics/histogram_base.cc

@@ -12,12 +12,14 @@

#include "base/logging.h"

#include "base/memory/scoped_ptr.h"

#include "base/metrics/histogram.h"

+#include "base/metrics/histogram_persistence.h"

#include "base/metrics/histogram_samples.h"

#include "base/metrics/sparse_histogram.h"

#include "base/metrics/statistics_recorder.h"

#include "base/pickle.h"

#include "base/process/process_handle.h"

#include "base/strings/stringprintf.h"

+#include "base/synchronization/lock.h"

Alexei Svitkine (slow) 2016/01/12 21:54:44 Doesn't seem like this header or the one on line 1

bcwhite 2016/01/13 13:38:29 Done.

#include "base/values.h"

namespace base {

« base/metrics/histogram.cc ('K') | « base/metrics/histogram_base.h ('k') | base/metrics/histogram_delta_serialization.h » ('j') | base/metrics/histogram_delta_serialization.h » ('J')