Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 142543002: Revert 245610 "Consistent fading behavior for touch editing handles" (Closed)

Created:
6 years, 11 months ago by dxie
Modified:
6 years, 11 months ago
Reviewers:
mohsen
CC:
chromium-reviews, jbauman+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Revert 245610 "Consistent fading behavior for touch editing handles" > Consistent fading behavior for touch editing handles > > The general rule is that touch editing handles should fade out when they > are dismissed, unless handles and text are moving relative to each > other. So, handles fade out except in following cases, in which they > disappear almost immediately (i.e. they fade out super quickly): > - When handle is dragged out of content view. In this case it should > actually scroll the contents, but that's a separate issue (see > crbug.com/269003); > - When starting touch scrolling or gesture navigation. > > BUG=313561 > > Review URL: https://codereview.chromium.org/138033014 TBR=mohsen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -50 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.cc View 7 chunks +9 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/touch/touch_editing_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 7 chunks +7 lines, -26 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dxie
6 years, 11 months ago (2014-01-19 07:12:24 UTC) #1
dxie
6 years, 11 months ago (2014-01-19 07:13:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r245823.

Powered by Google App Engine
This is Rietveld 408576698