Consistent fading behavior for touch editing handles

Consistent fading behavior for touch editing handles

The general rule is that touch editing handles should fade out when they
are dismissed, unless handles and text are moving relative to each
other. So, handles fade out except in following cases, in which they
disappear almost immediately (i.e. they fade out super quickly):
- When handle is dragged out of content view. In this case it should
  actually scroll the contents, but that's a separate issue (see
  crbug.com/269003);
- When starting touch scrolling or gesture navigation.

BUG=313561
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245610

[mohsen, 2014-01-16 22:11:42]

Please take a look...

[sky, 2014-01-16 23:15:01]

https://codereview.chromium.org/138033014/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.h (right):

https://codereview.chromium.org/138033014/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.h:125: virtual void
EndTouchEditing(bool quick) = 0;
If !quick means no animation, how about renaming to animate? |animate| is a lot
clearer as to what is going to happen.

https://codereview.chromium.org/138033014/diff/1/ui/views/controls/textfield/...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/138033014/diff/1/ui/views/controls/textfield/...
ui/views/controls/textfield/textfield.cc:1473:
touch_selection_controller_.reset(tsc);
Can the destructor imply HideHandles(false) so that you don't need 1471/1472?

[mohsen, 2014-01-17 02:09:40]

https://codereview.chromium.org/138033014/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.h (right):

https://codereview.chromium.org/138033014/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.h:125: virtual void
EndTouchEditing(bool quick) = 0;
On 2014/01/16 23:15:02, sky wrote:
> If !quick means no animation, how about renaming to animate? |animate| is a
lot
> clearer as to what is going to happen.

Actually it was first named |animate|. But, since it still has a super quick
animation, I renamed it to |quick|. If you think that we can consider this super
quick animation as "no animation", then I can rename it back to |animate|.

https://codereview.chromium.org/138033014/diff/1/ui/views/controls/textfield/...
File ui/views/controls/textfield/textfield.cc (right):

https://codereview.chromium.org/138033014/diff/1/ui/views/controls/textfield/...
ui/views/controls/textfield/textfield.cc:1473:
touch_selection_controller_.reset(tsc);
On 2014/01/16 23:15:02, sky wrote:
> Can the destructor imply HideHandles(false) so that you don't need 1471/1472?

Yep! Done.
Now, handles fade out in their destructor, unless they are previously hidden.
So, those lines are not needed anymore as well as this helper function.

[sky, 2014-01-17 15:46:54]

ic, leave it quick then, LGTM

[commit-bot: I haz the power, 2014-01-17 18:45:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mohsen@chromium.org/138033014/140001

[commit-bot: I haz the power, 2014-01-17 20:44:18]

Change committed as 245610