[Telemetry] Enable screenshot taking on Mac

[Telemetry] Enable screenshot taking on Mac

*This is a reland of https://codereview.chromium.org/1415133005/ which
was reverted because it failed on Mac 10.6

Mac 10.8, 10.9, 10.10 did pass the unittest:
https://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/10427/steps/telemetry_unittests/logs/stdio
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/10607/steps/telemetry_unittests/logs/stdio
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/3569/steps/telemetry_unittests/logs/stdio

This patch include the original patch + logic to disable unittest on Mac 10.5, 10.6, 10.7.

BUG=369490
Committed: https://crrev.com/22c1ed8e0f0b4756dfb447462e0dc7e8375657b4
Cr-Commit-Position: refs/heads/master@{#357019}

[nednguyen, 2015-10-30 00:00:26]

Description was changed from

==========
[Telemetry] Enable screenshot taking on Mac

BUG=369490
==========

to

==========
[Telemetry] Enable screenshot taking on Mac 10.7 and above

BUG=369490
==========

[nednguyen, 2015-10-30 00:05:06]

Description was changed from

==========
[Telemetry] Enable screenshot taking on Mac 10.7 and above

BUG=369490
==========

to

==========
[Telemetry] Enable screenshot taking on Mac 10.7 and above

*This is a reland of https://codereview.chromium.org/1415133005/ which
was reverted because it failed on Mac 10.6

Mac 10.8, 10.9, 10.10 did pass the unittest:
https://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/104...
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/106...
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/35...

BUG=369490
==========

[nednguyen, 2015-10-30 00:06:19]

Patchset #2 (id:20001) has been deleted

[nednguyen, 2015-10-30 00:12:20]

Description was changed from

==========
[Telemetry] Enable screenshot taking on Mac 10.7 and above

*This is a reland of https://codereview.chromium.org/1415133005/ which
was reverted because it failed on Mac 10.6

Mac 10.8, 10.9, 10.10 did pass the unittest:
https://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/104...
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/106...
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/35...

BUG=369490
==========

to

==========
[Telemetry] Enable screenshot taking on Mac

*This is a reland of https://codereview.chromium.org/1415133005/ which
was reverted because it failed on Mac 10.6

Mac 10.8, 10.9, 10.10 did pass the unittest:
https://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/104...
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/106...
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/35...

This patch include the original patch + logic to disable unittest on Mac 10.5,
10.6, 10.7.

BUG=369490
==========

[nednguyen, 2015-10-30 00:14:37]

Patchset #2 (id:40001) has been deleted

[nednguyen, 2015-10-30 00:15:01]

nednguyen@google.com changed reviewers:
+ eakuefner@chromium.org

[eakuefner, 2015-10-30 00:22:34]

I think this is okay because we're on to specifically only supporting 10.10 and
above on the perf waterfall. This is purely so we don't break compatibility with
the CQ.

https://codereview.chromium.org/1425163003/diff/60001/tools/telemetry/telemet...
File tools/telemetry/telemetry/core/platform_unittest.py (right):

https://codereview.chromium.org/1425163003/diff/60001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform_unittest.py:24:
logging.warning('Platform does not support screenshots, skipping test.')
We should be using self.skipTest, which is unittest's built-in functionality for
skipping tests.

The syntax is self.skipTest(reason)

https://codereview.chromium.org/1425163003/diff/60001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform_unittest.py:27: # recognizable on Mac
10.6 and pass on Mac 10.8, 10.8, 10.9.
Can you change this line to 'supported on Mac <10.8 (crbug.com/...)' and remove
the line below?

https://codereview.chromium.org/1425163003/diff/60001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform_unittest.py:32: return
similarly, self.skipTest('OS X version %s too old' %
self._platform.GetOSVersionName())

[nednguyen, 2015-10-30 00:35:36]

https://codereview.chromium.org/1425163003/diff/60001/tools/telemetry/telemet...
File tools/telemetry/telemetry/core/platform_unittest.py (right):

https://codereview.chromium.org/1425163003/diff/60001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform_unittest.py:24:
logging.warning('Platform does not support screenshots, skipping test.')
On 2015/10/30 00:22:34, eakuefner wrote:
> We should be using self.skipTest, which is unittest's built-in functionality
for
> skipping tests.
> 
> The syntax is self.skipTest(reason)

Done.

https://codereview.chromium.org/1425163003/diff/60001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform_unittest.py:27: # recognizable on Mac
10.6 and pass on Mac 10.8, 10.8, 10.9.
On 2015/10/30 00:22:34, eakuefner wrote:
> Can you change this line to 'supported on Mac <10.8 (crbug.com/...)' and
remove
> the line below?

Done.

https://codereview.chromium.org/1425163003/diff/60001/tools/telemetry/telemet...
tools/telemetry/telemetry/core/platform_unittest.py:32: return
On 2015/10/30 00:22:34, eakuefner wrote:
> similarly, self.skipTest('OS X version %s too old' %
> self._platform.GetOSVersionName())

Done.

[eakuefner, 2015-10-30 00:42:03]

lgtm

[nednguyen, 2015-10-30 00:48:09]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-10-30 00:49:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1425163003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1425163003/80001

[commit-bot: I haz the power, 2015-10-30 02:04:23]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-10-30 02:05:32]

Patchset 3 (id:??) landed as
https://crrev.com/22c1ed8e0f0b4756dfb447462e0dc7e8375657b4
Cr-Commit-Position: refs/heads/master@{#357019}