tools/telemetry/telemetry/internal/platform/mac_platform_backend.py - Issue 1425163003: [Telemetry] Enable screenshot taking on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/platform/mac_platform_backend.py

Issue 1425163003: [Telemetry] Enable screenshot taking on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ethan's comment Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform_unittest.py ('k') | tools/telemetry/telemetry/internal/testing/screenshot_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/internal/platform/mac_platform_backend.py

diff --git a/tools/telemetry/telemetry/internal/platform/mac_platform_backend.py b/tools/telemetry/telemetry/internal/platform/mac_platform_backend.py

index 52b5e21531314a7e0a6e5caa871832005099ead6..f33d72a51c0b72f28f7695ccfea2181e6b415c14 100644

--- a/tools/telemetry/telemetry/internal/platform/mac_platform_backend.py

+++ b/tools/telemetry/telemetry/internal/platform/mac_platform_backend.py

@@ -5,6 +5,7 @@

import ctypes

import os

import platform

+import subprocess

import sys

import time

@@ -151,6 +152,12 @@ class MacPlatformBackend(posix_platform_backend.PosixPlatformBackend):

raise NotImplementedError('Unknown mac version %s.' % os_version)

+ def CanTakeScreenshot(self):

+ return True

+ def TakeScreenshot(self, file_path):

+ return subprocess.call(['screencapture', file_path])

def CanFlushIndividualFilesFromSystemCache(self):

return False