gfx: Rename canvas SaveAndUnscale to UnscaleTheDeviceScaleFactor.

gfx: Rename canvas SaveAndUnscale to UnscaleTheDeviceScaleFactor.

This changes the method to only do the unscaling. Callers use a
ScopedCanvas instead. Then they don't need to call Restore()
themselves.

R=pkasting, sky

Committed: https://crrev.com/da76437a9d701587d08a93bbc4f37dd796f21124
Cr-Commit-Position: refs/heads/master@{#357172}

[danakj, 2015-10-29 22:55:17]

Description was changed from

==========
gfx: Rename canvas SaveAndUnscale to UnscaleTheDeviceScaleFactor.

This changes the method to only do the unscaling. Callers use a
ScopedCanvas instead.

R=pkasting, sky
==========

to

==========
gfx: Rename canvas SaveAndUnscale to UnscaleTheDeviceScaleFactor.

This changes the method to only do the unscaling. Callers use a
ScopedCanvas instead. Then they don't need to call Restore themselves.

R=pkasting, sky
==========

[danakj, 2015-10-29 22:55:25]

Description was changed from

==========
gfx: Rename canvas SaveAndUnscale to UnscaleTheDeviceScaleFactor.

This changes the method to only do the unscaling. Callers use a
ScopedCanvas instead. Then they don't need to call Restore themselves.

R=pkasting, sky
==========

to

==========
gfx: Rename canvas SaveAndUnscale to UnscaleTheDeviceScaleFactor.

This changes the method to only do the unscaling. Callers use a
ScopedCanvas instead. Then they don't need to call Restore()
themselves.

R=pkasting, sky
==========

[danakj, 2015-10-29 22:55:50]

I toyed with adding another constructor to ScopedCanvas or something, but this
was the most simple approach I think. PTAL

[Peter Kasting, 2015-10-29 23:11:09]

pkasting@chromium.org changed reviewers:
+ pkasting@chromium.org

[Peter Kasting, 2015-10-29 23:11:10]

LGTM, just naming quibbles

https://codereview.chromium.org/1425163002/diff/20001/ash/frame/default_heade...
File ash/frame/default_header_painter.cc (right):

https://codereview.chromium.org/1425163002/diff/20001/ash/frame/default_heade...
ash/frame/default_header_painter.cc:265: ScopedCanvas scoped(canvas);
The variable name "scoped" doesn't really pass style-guide muster -- I think you
should use "scoped_canvas" or "canvas_scoper" here and elsewhere in this change.

https://codereview.chromium.org/1425163002/diff/20001/ui/gfx/canvas.h
File ui/gfx/canvas.h (right):

https://codereview.chromium.org/1425163002/diff/20001/ui/gfx/canvas.h#newcode171
ui/gfx/canvas.h:171: float UnscaleTheDeviceScaleFactor();
This name is so verbose it reads poorly.  How about "UndoDeviceScale()", which
is admittedly slightly less accurate but seems clear enough and a lot less
wordy.

Or you could go in another direction and do "PrepareForPixelDrawing()" or the
like.

[sky, 2015-10-29 23:37:55]

LGTM

https://codereview.chromium.org/1425163002/diff/20001/ui/gfx/canvas.h
File ui/gfx/canvas.h (right):

https://codereview.chromium.org/1425163002/diff/20001/ui/gfx/canvas.h#newcode171
ui/gfx/canvas.h:171: float UnscaleTheDeviceScaleFactor();
On 2015/10/29 23:11:10, Peter Kasting wrote:
> This name is so verbose it reads poorly.  How about "UndoDeviceScale()", which
> is admittedly slightly less accurate but seems clear enough and a lot less
> wordy.
> 
> Or you could go in another direction and do "PrepareForPixelDrawing()" or the
> like.

+1 to Peter's first suggestion UndoDeviceScale.

[danakj, 2015-10-30 17:51:17]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-10-30 17:51:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1425163002/#ps40001
(title: "scopedunscale: .")

[danakj, 2015-10-30 17:51:22]

https://codereview.chromium.org/1425163002/diff/20001/ash/frame/default_heade...
File ash/frame/default_header_painter.cc (right):

https://codereview.chromium.org/1425163002/diff/20001/ash/frame/default_heade...
ash/frame/default_header_painter.cc:265: ScopedCanvas scoped(canvas);
On 2015/10/29 23:11:10, Peter Kasting wrote:
> The variable name "scoped" doesn't really pass style-guide muster -- I think
you
> should use "scoped_canvas" or "canvas_scoper" here and elsewhere in this
change.

Done.

https://codereview.chromium.org/1425163002/diff/20001/ui/gfx/canvas.h
File ui/gfx/canvas.h (right):

https://codereview.chromium.org/1425163002/diff/20001/ui/gfx/canvas.h#newcode171
ui/gfx/canvas.h:171: float UnscaleTheDeviceScaleFactor();
On 2015/10/29 23:37:54, sky wrote:
> On 2015/10/29 23:11:10, Peter Kasting wrote:
> > This name is so verbose it reads poorly.  How about "UndoDeviceScale()",
which
> > is admittedly slightly less accurate but seems clear enough and a lot less
> > wordy.
> > 
> > Or you could go in another direction and do "PrepareForPixelDrawing()" or
the
> > like.
> 
> +1 to Peter's first suggestion UndoDeviceScale.

Done. I used UndoDeviceScaleFactor(), because we never write just DeviceScale
(in code I've read), and often shorten to DSF in conversation etc.

[commit-bot: I haz the power, 2015-10-30 17:51:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1425163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1425163002/40001

[commit-bot: I haz the power, 2015-10-30 19:25:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-30 19:26:59]

Patchset 3 (id:??) landed as
https://crrev.com/da76437a9d701587d08a93bbc4f37dd796f21124
Cr-Commit-Position: refs/heads/master@{#357172}