Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 14251005: Change url to uri on LibraryMirror. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/mirrors/mirrors.dart » ('j') | sdk/lib/mirrors/mirrors.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors_impl.dart
diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart
index 6588649ba53bcea4296bdd5612118ba83cc62431..bff1926f488cba755718d58f5fe4d6f5a1183fd3 100644
--- a/runtime/lib/mirrors_impl.dart
+++ b/runtime/lib/mirrors_impl.dart
@@ -139,7 +139,7 @@ abstract class _LocalVMObjectMirrorImpl extends _LocalMirrorImpl {
abstract class _LocalObjectMirrorImpl extends _LocalVMObjectMirrorImpl
implements ObjectMirror {
_LocalObjectMirrorImpl(ref) : super(ref) {}
-
+
Future<InstanceMirror> invokeAsync(String memberName,
List positionalArguments,
[Map<String,dynamic> namedArguments]) {
@@ -682,8 +682,9 @@ class _LocalLibraryMirrorImpl extends _LocalObjectMirrorImpl
implements LibraryMirror {
_LocalLibraryMirrorImpl(ref,
this.simpleName,
- this.url,
- this.members) : super(ref) {}
+ String url,
+ this.members)
+ : this.uri = Uri.parse(url), super(ref) {}
final String simpleName;
@@ -704,7 +705,8 @@ class _LocalLibraryMirrorImpl extends _LocalObjectMirrorImpl
'LibraryMirror.location is not implemented');
}
- final String url;
+ String get url => uri.toString();
ahe 2013/04/15 13:24:48 Why keep "url"?
Johnni Winther 2013/04/17 09:40:33 Removed.
+ final Uri uri;
final Map<String, Mirror> members;
Map<String, ClassMirror> _classes = null;
« no previous file with comments | « no previous file | sdk/lib/mirrors/mirrors.dart » ('j') | sdk/lib/mirrors/mirrors.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698