Chromium Code Reviews| Index: sdk/lib/mirrors/mirrors.dart |
| diff --git a/sdk/lib/mirrors/mirrors.dart b/sdk/lib/mirrors/mirrors.dart |
| index 9813a0d9a74d553c33f4e6a4fbed692fcbaf84cb..cc694b99988b723ed009a4f47880f616cc15449d 100644 |
| --- a/sdk/lib/mirrors/mirrors.dart |
| +++ b/sdk/lib/mirrors/mirrors.dart |
| @@ -16,6 +16,7 @@ library dart.mirrors; |
| import 'dart:async'; |
| import 'dart:isolate'; |
| +import 'dart:uri'; |
| /** |
| * A [MirrorSystem] is the main interface used to reflect on a set of |
| @@ -174,7 +175,7 @@ abstract class DeclarationMirror implements Mirror { |
| abstract class ObjectMirror implements Mirror { |
| /** |
| * Invokes the named function and returns a mirror on the result. |
| - * The arguments must be instances of [InstanceMirror], [num], |
| + * The arguments must be instances of [InstanceMirror], [num], |
| * [String] or [bool]. |
| */ |
| /* TODO(turnidge): Properly document. |
| @@ -197,7 +198,7 @@ abstract class ObjectMirror implements Mirror { |
| * Invokes a setter and returns a mirror on the result. The setter |
| * may be either the implicit setter for a non-final field or a |
| * user-defined setter method. |
| - * The argument must be an instance of either [InstanceMirror], [num], |
| + * The argument must be an instance of either [InstanceMirror], [num], |
| * [String] or [bool]. |
| */ |
| /* TODO(turnidge): Handle ambiguous names.*/ |
| @@ -259,8 +260,8 @@ abstract class ClosureMirror implements InstanceMirror { |
| /** |
| * Executes the closure. |
| - * The arguments must be instances of [InstanceMirror], [num], |
| - * [String] or [bool]. |
| + * The arguments must be instances of [InstanceMirror], [num], |
| + * [String] or [bool]. |
| */ |
| Future<InstanceMirror> applyAsync(List<Object> positionalArguments, |
| [Map<String,Object> namedArguments]); |
| @@ -279,12 +280,19 @@ abstract class ClosureMirror implements InstanceMirror { |
| */ |
| abstract class LibraryMirror implements DeclarationMirror, ObjectMirror { |
| /** |
| + * Deprecated: Use [uri] instead. |
|
ahe
2013/04/15 13:24:48
Today is a great day to get rid of deprecated stuf
Johnni Winther
2013/04/17 09:40:33
Removed.
|
| + * |
| * The url of the library. |
| * |
| * TODO(turnidge): Document where this url comes from. Will this |
| * value be sensible? |
| */ |
| - String get url; |
| + String get url => uri.toString(); |
| + |
| + /** |
| + * The absolute uri of the library. |
| + */ |
| + Uri get uri; |
| /** |
| * An immutable map from from names to mirrors for all members in |
| @@ -433,7 +441,7 @@ abstract class ClassMirror implements TypeMirror, ObjectMirror { |
| /** |
| * Invokes the named constructor and returns a mirror on the result. |
| - * The arguments must be instances of [InstanceMirror], [num], |
| + * The arguments must be instances of [InstanceMirror], [num], |
| */ |
| /* TODO(turnidge): Properly document.*/ |
| Future<InstanceMirror> newInstanceAsync(String constructorName, |