Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: third_party/WebKit/Source/core/input/EventHandler.h

Issue 1425053002: Fire pointermoves for mousemove events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: TestExpectations Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/EventHandler.h
diff --git a/third_party/WebKit/Source/core/input/EventHandler.h b/third_party/WebKit/Source/core/input/EventHandler.h
index 4a059969bab61bfeadf6866c922d6a28e998bb0e..20aee780bb665791bcaca6eca97deba33b6bbdbb 100644
--- a/third_party/WebKit/Source/core/input/EventHandler.h
+++ b/third_party/WebKit/Source/core/input/EventHandler.h
@@ -283,7 +283,7 @@ private:
void updateMouseEventTargetNode(Node*, const PlatformMouseEvent&);
// Returns true when the sent PE has defaultPrevented or defaultHandled set.
- bool dispatchPointerEventForMouseEvent(Node* target, const AtomicString& eventType, const PlatformMouseEvent&, Node* relatedTarget = nullptr);
+ bool dispatchPointerEvent(Node* target, const AtomicString& eventType, const PlatformMouseEvent&, Node* relatedTarget = nullptr);
// Dispatches mouseover, mouseout, mouseenter and mouseleave events to appropriate nodes when the mouse pointer moves from one node to another.
void sendMouseEventsForNodeTransition(Node*, Node*, const PlatformMouseEvent&);
@@ -291,6 +291,15 @@ private:
MouseEventWithHitTestResults prepareMouseEvent(const HitTestRequest&, const PlatformMouseEvent&);
bool dispatchMouseEvent(const AtomicString& eventType, Node* target, int clickCount, const PlatformMouseEvent&);
+
+ // Dispatches ME after corresponding PE provided the PE has not been canceled. The eventType arg
+ // must be a mouse event that can be gated though a preventDefaulted pointerdown (i.e., one of
+ // {mousedown, mousemove, mouseup}).
+ // TODO(mustaq): Can we avoid the clickCount param, instead use PlatformMouseEvent's count?
+ // Same applied to dispatchMouseEvent() above.
+ bool updatePointerTargetAndDispatchEvents(const AtomicString& mouseEventType, Node* target,
+ int clickCount, const PlatformMouseEvent&);
+
bool dispatchDragEvent(const AtomicString& eventType, Node* target, const PlatformMouseEvent&, DataTransfer*);
void clearDragDataTransfer();
@@ -341,7 +350,7 @@ private:
// the given element.
bool slideFocusOnShadowHostIfNecessary(const Element&);
- void dispatchPointerEventsForTouchEvent(const PlatformTouchEvent&, WillBeHeapVector<TouchInfo>&);
+ void dispatchPointerEvents(const PlatformTouchEvent&, WillBeHeapVector<TouchInfo>&);
void sendPointerCancels(WillBeHeapVector<TouchInfo>&);
bool dispatchTouchEvents(const PlatformTouchEvent&, WillBeHeapVector<TouchInfo>&, bool, bool);

Powered by Google App Engine
This is Rietveld 408576698