Using copy_ex to copy assets

Using copy_ex to copy assets

Used copy_ex to copy assets and fixed some wrong dependence

This patch is a subset of a large patch which made bots
flaky, the flaky can't reproduced by trybot and cq dryrun.
So, split the large patch to two small ones, this is the
first one, another one does renaming v8 data file.

it also added the code (in ApkAssets.java and copy_ex.py) to dump
the information once bot failed.

The original patch
https://codereview.chromium.org/1422793004/

BUG=540788, 547235
TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick@chromium.org,mef@chromium.org,rmcilroy@chromium.org,dtrainor@chromium.org,cpu@chromium.org

Committed: https://crrev.com/0cd95d092228247f8f6f5e4177c00d334a65a99c
Cr-Commit-Position: refs/heads/master@{#357024}

[michaelbai, 2015-10-28 21:08:05]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-28 21:09:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424983004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424983004/20001

[michaelbai, 2015-10-28 21:22:52]

Description was changed from

==========
Using copy_ex to copy assets

BUG=
==========

to

==========
Using copy_ex to copy assets

Used copy_ex to copy assets and fixed some wrong dependence

This patch is a subset of a large patch which made bots
flaky, the flaky can't reproduced by trybot and cq dryrun.
So, split the large patch to two small ones

it added the code to dump the information once bot failed.

The original patch 
https://codereview.chromium.org/1422793004/

BUG=540788, 547235
==========

[michaelbai, 2015-10-28 21:26:12]

Description was changed from

==========
Using copy_ex to copy assets

Used copy_ex to copy assets and fixed some wrong dependence

This patch is a subset of a large patch which made bots
flaky, the flaky can't reproduced by trybot and cq dryrun.
So, split the large patch to two small ones

it added the code to dump the information once bot failed.

The original patch 
https://codereview.chromium.org/1422793004/

BUG=540788, 547235
==========

to

==========
Using copy_ex to copy assets

Used copy_ex to copy assets and fixed some wrong dependence

This patch is a subset of a large patch which made bots
flaky, the flaky can't reproduced by trybot and cq dryrun.
So, split the large patch to two small ones, this is the
first one.

it also added the code to dump the information once bot failed.

The original patch 
https://codereview.chromium.org/1422793004/

BUG=540788, 547235
==========

[michaelbai, 2015-10-29 03:27:40]

Patchset #1 (id:1) has been deleted

[michaelbai, 2015-10-29 03:27:53]

Patchset #1 (id:20001) has been deleted

[michaelbai, 2015-10-29 03:36:51]

The CQ bit was checked by michaelbai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 03:37:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424983004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424983004/60001

[michaelbai, 2015-10-29 03:41:54]

michaelbai@chromium.org changed reviewers:
+ jbudorick@chromium.org, rmcilroy@chromium.org

[michaelbai, 2015-10-29 03:49:52]

Description was changed from

==========
Using copy_ex to copy assets

Used copy_ex to copy assets and fixed some wrong dependence

This patch is a subset of a large patch which made bots
flaky, the flaky can't reproduced by trybot and cq dryrun.
So, split the large patch to two small ones, this is the
first one.

it also added the code to dump the information once bot failed.

The original patch 
https://codereview.chromium.org/1422793004/

BUG=540788, 547235
==========

to

==========
Using copy_ex to copy assets

Used copy_ex to copy assets and fixed some wrong dependence

This patch is a subset of a large patch which made bots
flaky, the flaky can't reproduced by trybot and cq dryrun.
So, split the large patch to two small ones, this is the
first one.

it also added the code (in ApkAssets.java and copy_ex.py) to dump
the information once bot failed.

The original patch 
https://codereview.chromium.org/1422793004/

BUG=540788, 547235
==========

[michaelbai, 2015-10-29 03:54:57]

jbudorick@ please review the overall patch
 
rmcilroy@ please review the new change in base/andrioid/ which is used to dump
the asset directory when loading v8 file failed, it is the failure of bots

I will TBR other directory owner, as this code was approved.

Thanks

[michaelbai, 2015-10-29 03:56:06]

Description was changed from

==========
Using copy_ex to copy assets

Used copy_ex to copy assets and fixed some wrong dependence

This patch is a subset of a large patch which made bots
flaky, the flaky can't reproduced by trybot and cq dryrun.
So, split the large patch to two small ones, this is the
first one.

it also added the code (in ApkAssets.java and copy_ex.py) to dump
the information once bot failed.

The original patch 
https://codereview.chromium.org/1422793004/

BUG=540788, 547235
==========

to

==========
Using copy_ex to copy assets

Used copy_ex to copy assets and fixed some wrong dependence

This patch is a subset of a large patch which made bots
flaky, the flaky can't reproduced by trybot and cq dryrun.
So, split the large patch to two small ones, this is the
first one, another one does renaming v8 data file.

it also added the code (in ApkAssets.java and copy_ex.py) to dump
the information once bot failed.

The original patch 
https://codereview.chromium.org/1422793004/

BUG=540788, 547235
==========

[commit-bot: I haz the power, 2015-10-29 05:11:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 05:11:36]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2015-10-29 12:02:22]

Debugging code in base/android LGTM until bug is fixed.

[jbudorick, 2015-10-29 13:06:14]

fine otherwise

https://codereview.chromium.org/1424983004/diff/60001/build/android/gyp/copy_...
File build/android/gyp/copy_ex.py (right):

https://codereview.chromium.org/1424983004/diff/60001/build/android/gyp/copy_...
build/android/gyp/copy_ex.py:36: sys.stderr.write("CopyFile: " + f + " " + dest
+ "\n")
We do not want this in the build output.

[michaelbai, 2015-10-29 14:56:44]

https://codereview.chromium.org/1424983004/diff/60001/build/android/gyp/copy_...
File build/android/gyp/copy_ex.py (right):

https://codereview.chromium.org/1424983004/diff/60001/build/android/gyp/copy_...
build/android/gyp/copy_ex.py:36: sys.stderr.write("CopyFile: " + f + " " + dest
+ "\n")
On 2015/10/29 13:06:14, jbudorick wrote:
> We do not want this in the build output.

Let's keep it for a while, I did see 'CopyFile' build output in bot, it should
be generated by copy command in gyp, it will make me easy to figure out what
happen, and also will  be removed afterwards.

[jbudorick, 2015-10-29 14:57:29]

https://codereview.chromium.org/1424983004/diff/60001/build/android/gyp/copy_...
File build/android/gyp/copy_ex.py (right):

https://codereview.chromium.org/1424983004/diff/60001/build/android/gyp/copy_...
build/android/gyp/copy_ex.py:36: sys.stderr.write("CopyFile: " + f + " " + dest
+ "\n")
On 2015/10/29 14:56:44, michaelbai wrote:
> On 2015/10/29 13:06:14, jbudorick wrote:
> > We do not want this in the build output.
> 
> Let's keep it for a while, I did see 'CopyFile' build output in bot, it should
> be generated by copy command in gyp, it will make me easy to figure out what
> happen, and also will  be removed afterwards. 

No. Having builds making unnecessary noise is a problem.

[jbudorick, 2015-10-29 15:03:19]

https://codereview.chromium.org/1424983004/diff/60001/build/android/gyp/copy_...
File build/android/gyp/copy_ex.py (right):

https://codereview.chromium.org/1424983004/diff/60001/build/android/gyp/copy_...
build/android/gyp/copy_ex.py:36: sys.stderr.write("CopyFile: " + f + " " + dest
+ "\n")
On 2015/10/29 14:57:29, jbudorick wrote:
> On 2015/10/29 14:56:44, michaelbai wrote:
> > On 2015/10/29 13:06:14, jbudorick wrote:
> > > We do not want this in the build output.
> > 
> > Let's keep it for a while, I did see 'CopyFile' build output in bot, it
should
> > be generated by copy command in gyp, it will make me easy to figure out what
> > happen, and also will  be removed afterwards. 
> 
> No. Having builds making unnecessary noise is a problem.

Specifically, there'd be a crbug within hours about developers' local builds
producing output like this:

jbudorick@jbudorick:/usr/local/google/code/clankium/src$ ninja -C out/Debug
-j500 -l15 chrome_public_apk
ninja: Entering directory `out/Debug'
[20/291] ACTION chrome_android_paks_copy:
chrome_android_paks_copy_copy_ex_288d481c743da79f38d05f854ce0b718
CopyFile: ../../out/Debug/resources.pak ../../out/Debug/assets/chrome_public_apk
CopyFile: ../../out/Debug/chrome_100_percent.pak
../../out/Debug/assets/chrome_public_apk
CopyFile: ../../out/Debug/icudtl.dat ../../out/Debug/assets/chrome_public_apk
CopyFile: ../../out/Debug/natives_blob.bin
../../out/Debug/assets/chrome_public_apk
CopyFile: ../../out/Debug/snapshot_blob.bin
../../out/Debug/assets/chrome_public_apk
...

[michaelbai, 2015-10-29 17:00:45]

PTAL

https://codereview.chromium.org/1424983004/diff/60001/build/android/gyp/copy_...
File build/android/gyp/copy_ex.py (right):

https://codereview.chromium.org/1424983004/diff/60001/build/android/gyp/copy_...
build/android/gyp/copy_ex.py:36: sys.stderr.write("CopyFile: " + f + " " + dest
+ "\n")
On 2015/10/29 15:03:19, jbudorick wrote:
> On 2015/10/29 14:57:29, jbudorick wrote:
> > On 2015/10/29 14:56:44, michaelbai wrote:
> > > On 2015/10/29 13:06:14, jbudorick wrote:
> > > > We do not want this in the build output.
> > > 
> > > Let's keep it for a while, I did see 'CopyFile' build output in bot, it
> should
> > > be generated by copy command in gyp, it will make me easy to figure out
what
> > > happen, and also will  be removed afterwards. 
> > 
> > No. Having builds making unnecessary noise is a problem.
> 
> Specifically, there'd be a crbug within hours about developers' local builds
> producing output like this:
> 
> jbudorick@jbudorick:/usr/local/google/code/clankium/src$ ninja -C out/Debug
> -j500 -l15 chrome_public_apk
> ninja: Entering directory `out/Debug'
> [20/291] ACTION chrome_android_paks_copy:
> chrome_android_paks_copy_copy_ex_288d481c743da79f38d05f854ce0b718
> CopyFile: ../../out/Debug/resources.pak
../../out/Debug/assets/chrome_public_apk
> CopyFile: ../../out/Debug/chrome_100_percent.pak
> ../../out/Debug/assets/chrome_public_apk
> CopyFile: ../../out/Debug/icudtl.dat ../../out/Debug/assets/chrome_public_apk
> CopyFile: ../../out/Debug/natives_blob.bin
> ../../out/Debug/assets/chrome_public_apk
> CopyFile: ../../out/Debug/snapshot_blob.bin
> ../../out/Debug/assets/chrome_public_apk
> ...
> 

Removed

[jbudorick, 2015-10-29 18:57:38]

https://codereview.chromium.org/1424983004/diff/80001/content/content_shell.gypi
File content/content_shell.gypi (left):

https://codereview.chromium.org/1424983004/diff/80001/content/content_shell.g...
content/content_shell.gypi:448: 'pak_output':
'<(PRODUCT_DIR)/content_shell.pak',
er, actually, what's with this change? Why are we changing non-android?

[michaelbai, 2015-10-29 19:29:55]

https://codereview.chromium.org/1424983004/diff/80001/content/content_shell.gypi
File content/content_shell.gypi (left):

https://codereview.chromium.org/1424983004/diff/80001/content/content_shell.g...
content/content_shell.gypi:448: 'pak_output':
'<(PRODUCT_DIR)/content_shell.pak',
On 2015/10/29 18:57:38, jbudorick wrote:
> er, actually, what's with this change? Why are we changing non-android?

This didn't change non-android, see line 430 on right side.


For android, It is changed to output pak to '<(PRODUCT_DIR)/content_shell.pak",
then copy to asset directory in content.gyp:content_shell_assets_copy, copy_ex
will remove the directory, so the file can't be generated to asset's directory.

[jbudorick, 2015-10-29 19:31:19]

lgtm

https://codereview.chromium.org/1424983004/diff/80001/content/content_shell.gypi
File content/content_shell.gypi (left):

https://codereview.chromium.org/1424983004/diff/80001/content/content_shell.g...
content/content_shell.gypi:448: 'pak_output':
'<(PRODUCT_DIR)/content_shell.pak',
On 2015/10/29 19:29:54, michaelbai wrote:
> On 2015/10/29 18:57:38, jbudorick wrote:
> > er, actually, what's with this change? Why are we changing non-android?
> 
> This didn't change non-android, see line 430 on right side.
> 
> 
> For android, It is changed to output pak to
'<(PRODUCT_DIR)/content_shell.pak",
> then copy to asset directory in content.gyp:content_shell_assets_copy, copy_ex
> will remove the directory, so the file can't be generated to asset's
directory.

Oh, right. Sorry about that.

[gunsch, 2015-10-29 19:33:58]

gunsch@chromium.org changed reviewers:
+ gunsch@chromium.org

[gunsch, 2015-10-29 19:33:58]

chromecast/ note: I think you will also need to update:

https://code.google.com/p/chromium/codesearch#chromium/src/chromecast/base/ca...

[gunsch, 2015-10-29 19:35:27]

Actually, ignore my comment, I got too eager. It looks like the pak will still
be extracted to the same location on the Android system?

[michaelbai, 2015-10-29 20:37:43]

On 2015/10/29 19:35:27, gunsch wrote:
> Actually, ignore my comment, I got too eager. It looks like the pak will still
> be extracted to the same location on the Android system?

Thanks for checking this, this patch doesn't change anything inside the apk, and
will not touch the file you pointed, but for your specific file, it might
launched in Java,
https://code.google.com/p/chromium/codesearch#chromium/src/chromecast/app/cas...

[michaelbai, 2015-10-29 20:38:56]

Description was changed from

==========
Using copy_ex to copy assets

Used copy_ex to copy assets and fixed some wrong dependence

This patch is a subset of a large patch which made bots
flaky, the flaky can't reproduced by trybot and cq dryrun.
So, split the large patch to two small ones, this is the
first one, another one does renaming v8 data file.

it also added the code (in ApkAssets.java and copy_ex.py) to dump
the information once bot failed.

The original patch 
https://codereview.chromium.org/1422793004/

BUG=540788, 547235
==========

to

==========
Using copy_ex to copy assets

Used copy_ex to copy assets and fixed some wrong dependence

This patch is a subset of a large patch which made bots
flaky, the flaky can't reproduced by trybot and cq dryrun.
So, split the large patch to two small ones, this is the
first one, another one does renaming v8 data file.

it also added the code (in ApkAssets.java and copy_ex.py) to dump
the information once bot failed.

The original patch 
https://codereview.chromium.org/1422793004/

BUG=540788, 547235
TBR=jochen@chromium.org,dpranke@chromium.org,halliwell@chromium.org,jbudorick...
==========

[michaelbai, 2015-10-29 20:39:33]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2015-10-29 20:39:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1424983004/#ps80001
(title: "remvoe build log")

[commit-bot: I haz the power, 2015-10-29 20:40:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424983004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424983004/80001

[commit-bot: I haz the power, 2015-10-29 23:32:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 23:32:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[michaelbai, 2015-10-30 00:58:19]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2015-10-30 00:58:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424983004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424983004/80001

[commit-bot: I haz the power, 2015-10-30 02:17:04]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-10-30 02:17:53]

Patchset 3 (id:??) landed as
https://crrev.com/0cd95d092228247f8f6f5e4177c00d334a65a99c
Cr-Commit-Position: refs/heads/master@{#357024}