Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: src/IceInstARM32.h

Issue 1424923005: Add workaround to allow testing of ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Remove unnecessary addition of ARM32 local (assembler) label. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceInstARM32.h
diff --git a/src/IceInstARM32.h b/src/IceInstARM32.h
index 28317d270f13cff97b6dd338fe31fe0855d48c4b..cf3ad897006f40e92f7ed73c1f28efa0b7e84724 100644
--- a/src/IceInstARM32.h
+++ b/src/IceInstARM32.h
@@ -334,6 +334,10 @@ public:
Vsub
};
+ bool isIasSafe(InstKind Kind) const {
+ return !BuildDefs::checkIasmSafe() || isIasSafeImpl(Kind);
+ }
+
static const char *getWidthString(Type Ty);
static const char *getVecWidthString(Type Ty);
static CondARM32::Cond getOppositeCondition(CondARM32::Cond Cond);
@@ -354,6 +358,10 @@ protected:
return Inst->getKind() == static_cast<InstKind>(MyKind);
}
+ // Returns true if ARM instruction of Kind is in safe list for
+ // the integrated assembler.
+ bool isIasSafeImpl(InstKind Kind) const;
+
// Generates text of assembly instruction using method emit(), and then adds
// to the assembly buffer as a Fixup.
void emitUsingTextFixup(const Cfg *Func) const;
« no previous file with comments | « src/IceBuildDefs.h ('k') | src/IceInstARM32.cpp » ('j') | src/IceInstARM32.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698