Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1424923004: Add StaticUse for more precise registration of statically known element use. (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add StaticUse for more precise registration of statically known element use. BUG= R=sigurdm@google.com Committed: https://github.com/dart-lang/sdk/commit/57538d804d50b32daa772349a643255bcc1dde92

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+754 lines, -604 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 7 chunks +9 lines, -108 lines 0 comments Download
M pkg/compiler/lib/src/common/registry.dart View 4 chunks +8 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 5 chunks +9 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 10 chunks +40 lines, -83 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 9 chunks +25 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart View 5 chunks +16 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 13 chunks +51 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 2 chunks +9 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 4 chunks +11 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 47 chunks +182 lines, -95 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 5 chunks +6 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 5 chunks +8 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 23 chunks +70 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 4 chunks +50 lines, -15 lines 0 comments Download
A pkg/compiler/lib/src/universe/use.dart View 1 1 chunk +198 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 10 chunks +35 lines, -117 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Johnni Winther
Main changes in universe/use.dart, common/registry.dart and universe/universe.dart
5 years, 1 month ago (2015-11-02 09:56:47 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1424923004/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1424923004/diff/1/pkg/compiler/lib/src/compiler.dart#newcode910 pkg/compiler/lib/src/compiler.dart:910: enqueuer.resolution.registerStaticUse(new StaticUse.foreignUse(main)); ? https://codereview.chromium.org/1424923004/diff/1/pkg/compiler/lib/src/enqueue.dart File pkg/compiler/lib/src/enqueue.dart (right): https://codereview.chromium.org/1424923004/diff/1/pkg/compiler/lib/src/enqueue.dart#newcode622 ...
5 years, 1 month ago (2015-11-02 11:19:57 UTC) #3
sigurdm
LGTM
5 years, 1 month ago (2015-11-02 11:19:59 UTC) #4
Johnni Winther
https://codereview.chromium.org/1424923004/diff/1/pkg/compiler/lib/src/compiler.dart File pkg/compiler/lib/src/compiler.dart (right): https://codereview.chromium.org/1424923004/diff/1/pkg/compiler/lib/src/compiler.dart#newcode910 pkg/compiler/lib/src/compiler.dart:910: enqueuer.resolution.registerStaticUse(new StaticUse.foreignUse(main)); On 2015/11/02 11:19:56, sigurdm wrote: > ? ...
5 years, 1 month ago (2015-11-02 13:23:25 UTC) #5
Johnni Winther
5 years, 1 month ago (2015-11-02 13:46:14 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
57538d804d50b32daa772349a643255bcc1dde92 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698