pkg/compiler/lib/src/js_backend/codegen/glue.dart - Issue 1424923004: Add StaticUse for more precise registration of statically known element use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/glue.dart

Issue 1424923004: Add StaticUse for more precise registration of statically known element use. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/codegen/codegen.dart ('k') | pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/codegen/glue.dart

diff --git a/pkg/compiler/lib/src/js_backend/codegen/glue.dart b/pkg/compiler/lib/src/js_backend/codegen/glue.dart

index 2c0d9ad59f24dafb451fea9400aa80f8941673af..192c3cbe1148d52dfa6a03e51bf12b06784261ad 100644

--- a/pkg/compiler/lib/src/js_backend/codegen/glue.dart

+++ b/pkg/compiler/lib/src/js_backend/codegen/glue.dart

@@ -277,7 +277,7 @@ class Glue {

classElement == _helpers.jsBoolClass ||

classElement == _compiler.coreClasses.boolClass;

- // TODO(sra): Should this be part of CodegenRegistry?

+ // TODO(sra,johnniwinther): Should this be part of CodegenRegistry?

void registerNativeBehavior(NativeBehavior nativeBehavior, node) {

if (nativeBehavior == null) return;

_enqueuer.nativeEnqueuer.registerNativeBehavior(nativeBehavior, node);