Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(53)

Issue 1424913002: Fix toolbar drawing problem when clearing the clip rect. (Closed)

Created:
4 years, 3 months ago by Ted C
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2526
Target Ref:
refs/pending/branch-heads/2526
Project:
chromium
Visibility:
Public.

Description

Fix toolbar drawing problem when clearing the clip rect. To repro this, it required changing the source code to force the bad state, but the result is very consistent with bugs we have received on this. The changes made were: 1.) Exit the overview mode in Activity#onStart 2.) Change LayoutManagerChrome#hideOverview(false) Old code: startHiding(Tab.INVALID_TAB_ID, false); doneHiding(); New code: activeLayout.onTabSelecting(time(), Tab.INVALID_TAB_ID); activeLayout.forceAnimationToFinish(); At this point, go to the tab switcher and hit the recents button twice. Chrome should have exited the tab switcher and every few times the toolbar would either be half clipped or fully clipped. Added logs and it only would be broken if we ever set a clip rect (sometimes it was skipped entirely as the animations start and finish pre-empted it). BUG=515522 Review URL: https://codereview.chromium.org/1408773003 Cr-Commit-Position: refs/heads/master@{#354948} Committed: https://chromium.googlesource.com/chromium/src/+/82895c55b876484395c3967d8d827d0b1133f94e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ted C
4 years, 3 months ago (2015-10-27 23:34:52 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
82895c55b876484395c3967d8d827d0b1133f94e.

Powered by Google App Engine
This is Rietveld 408576698