Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(206)

Issue 1408773003: Fix toolbar drawing problem when clearing the clip rect. (Closed)

Created:
4 years, 11 months ago by Ted C
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix toolbar drawing problem when clearing the clip rect. To repro this, it required changing the source code to force the bad state, but the result is very consistent with bugs we have received on this. The changes made were: 1.) Exit the overview mode in Activity#onStart 2.) Change LayoutManagerChrome#hideOverview(false) Old code: startHiding(Tab.INVALID_TAB_ID, false); doneHiding(); New code: activeLayout.onTabSelecting(time(), Tab.INVALID_TAB_ID); activeLayout.forceAnimationToFinish(); At this point, go to the tab switcher and hit the recents button twice. Chrome should have exited the tab switcher and every few times the toolbar would either be half clipped or fully clipped. Added logs and it only would be broken if we ever set a clip rect (sometimes it was skipped entirely as the animations start and finish pre-empted it). BUG=515522 Committed: https://crrev.com/b81da0de163194dc03cb651b3af6ed52c2d91fbd Cr-Commit-Position: refs/heads/master@{#354948}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ted C
PTAL
4 years, 11 months ago (2015-10-20 00:38:47 UTC) #2
aurimas (slooooooooow)
lgtm
4 years, 11 months ago (2015-10-20 00:41:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408773003/1
4 years, 11 months ago (2015-10-20 00:42:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-10-20 01:16:55 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2015-10-20 01:17:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b81da0de163194dc03cb651b3af6ed52c2d91fbd
Cr-Commit-Position: refs/heads/master@{#354948}

Powered by Google App Engine
This is Rietveld 408576698