Issue 14249007: chromeos: Perform strict check on parent-shild relationship of DriveResourceMetadata DB

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14249007: chromeos: Perform strict check on parent-shild relationship of DriveResourceMetadata DB (Closed)

Created:
7 years, 8 months ago by hashimoto

Modified:
7 years, 8 months ago

Reviewers:
hidehiko

CC:
chromium-reviews, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Perform strict check on parent-shild relationship of DriveResourceMetadata DB Original code could not detect an error when the parent entry is missing. BUG=232054 TEST=unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194791

Patch Set 1 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -7 lines)			Patch
	M	chrome/browser/chromeos/drive/drive_resource_metadata_storage.cc	View		2 chunks	+13 lines, -2 lines	0 comments	Download
	M	chrome/browser/chromeos/drive/drive_resource_metadata_storage_unittest.cc	View		2 chunks	+32 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hashimoto

7 years, 8 months ago (2013-04-18 05:53:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r194791 (presubmit successful).

Expand Messages | Collapse Messages