chromeos: Perform strict check on parent-shild relationship of DriveResourceMetadata DB

chrome/browser/chromeos/drive/drive_resource_metadata_storage_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/drive_resource_metadata_storage.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/file_util.h"
@@ skipping 254 matching lines @@
 }
 
 TEST_F(DriveResourceMetadataStorageTest, CheckValidity) {
   const std::string key1 = "foo";
   const std::string name1 = "hoge";
   const std::string key2 = "bar";
   const std::string name2 = "fuga";
   const std::string key3 = "boo";
   const std::string name3 = "piyo";
 
+  // Empty storage is valid.
+  EXPECT_TRUE(CheckValidity());
+
   // Put entry with key1.
   DriveEntryProto entry;
   entry.set_resource_id(key1);
   entry.set_base_name(name1);
   storage_->PutEntry(entry);
   EXPECT_TRUE(CheckValidity());
 
   // Put entry with key2 under key1.
   entry.set_resource_id(key2);
   entry.set_parent_resource_id(key1);
   entry.set_base_name(name2);
   storage_->PutEntry(entry);
   EXPECT_FALSE(CheckValidity());  // Missing parent-child relationship.
 
   // Add missing parent-child relationship between key1 and key2.
   storage_->PutChild(key1, name2, key2);
   EXPECT_TRUE(CheckValidity());
 
-  // Add parent-child relationship between key1 and key3.
-  storage_->PutChild(key1, name3, key3);
+  // Add parent-child relationship between key2 and key3.
+  storage_->PutChild(key2, name3, key3);
   EXPECT_FALSE(CheckValidity());  // key3 is not stored in the storage.
 
-  // Put entry with key3 under key1.
+  // Put entry with key3 under key2.
   entry.set_resource_id(key3);
-  entry.set_parent_resource_id(key1);
+  entry.set_parent_resource_id(key2);
   entry.set_base_name(name3);
   storage_->PutEntry(entry);
   EXPECT_TRUE(CheckValidity());
 
   // Parent-child relationship with wrong name.
-  storage_->PutChild(key1, name2, key3);
+  storage_->RemoveChild(key2, name3);
   EXPECT_FALSE(CheckValidity());
+  storage_->PutChild(key2, name2, key3);
+  EXPECT_FALSE(CheckValidity());
+
+  // Fix up the relationship between key2 and key3.
+  storage_->RemoveChild(key2, name2);
+  EXPECT_FALSE(CheckValidity());
+  storage_->PutChild(key2, name3, key3);
+  EXPECT_TRUE(CheckValidity());
+
+  // Remove key2.
+  storage_->RemoveChild(key1, name2);
+  EXPECT_FALSE(CheckValidity());
+  storage_->RemoveEntry(key2);
+  EXPECT_FALSE(CheckValidity());
+
+  // Remove key3.
+  storage_->RemoveChild(key2, name3);
+  EXPECT_FALSE(CheckValidity());
+  storage_->RemoveEntry(key3);
+  EXPECT_TRUE(CheckValidity());
+
+  // Remove key1.
+  storage_->RemoveEntry(key1);
+  EXPECT_TRUE(CheckValidity());
 }
 
 }  // namespace drive