Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1424873003: Subzero. ARM32. Implements the Availability Optimization. (Closed)

Created:
5 years, 1 month ago by John
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, Karl, sehr
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero. ARM32. Implements the Availability Optimization. Implements the Availability optimization: a = b x = f(a, c) becomes a = b x = f(b, c) This only triggers if b is an infinite-weight temporary, and it prevents a potential spill at the cost of higher register pressure. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=562233c890ea6d2a834962edf3ccf9db14356683

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M src/IceTargetLoweringARM32.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
M tests_lit/llvm2ice_tests/callindirect.pnacl.ll View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
John
5 years, 1 month ago (2015-10-27 20:52:01 UTC) #2
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-10-27 21:45:51 UTC) #5
John
5 years, 1 month ago (2015-10-28 12:48:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
562233c890ea6d2a834962edf3ccf9db14356683 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698