Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 1424783003: CSS: Use UINT_MAX for ~ sibling invalidation (Closed)

Created:
5 years, 1 month ago by Eric Willigers
Modified:
5 years, 1 month ago
Reviewers:
Timothy Loh, rune
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS: Use UINT_MAX for ~ sibling invalidation Set siblingFeatures->maxDirectAdjacentSelectors to UINT_MAX as std::numeric_limits<unsigned>::max() is verbose. R=timloh@chromium.org CC=esprehn@chromium.org BUG=378135 Committed: https://crrev.com/26042e97bf09de2ef5de149272bf53e77914fbfd Cr-Commit-Position: refs/heads/master@{#356495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/core/css/RuleFeature.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Eric Willigers
5 years, 1 month ago (2015-10-27 01:42:47 UTC) #1
rune
5 years, 1 month ago (2015-10-27 09:36:43 UTC) #3
rune
lgtm
5 years, 1 month ago (2015-10-27 09:36:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424783003/1
5 years, 1 month ago (2015-10-27 19:43:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/126431)
5 years, 1 month ago (2015-10-28 00:51:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424783003/1
5 years, 1 month ago (2015-10-28 00:59:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-28 02:16:31 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 02:17:40 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26042e97bf09de2ef5de149272bf53e77914fbfd
Cr-Commit-Position: refs/heads/master@{#356495}

Powered by Google App Engine
This is Rietveld 408576698