third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp - Issue 1424783003: CSS: Use UINT_MAX for ~ sibling invalidation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp

Issue 1424783003: CSS: Use UINT_MAX for ~ sibling invalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp

diff --git a/third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp b/third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp

index e75962cfa2ad7646739ce496f0ec5bb2599709c3..f27597af8df9d71fd1c7474fa6a941555cf458cd 100644

--- a/third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp

+++ b/third_party/WebKit/Source/core/css/RuleFeatureSetTest.cpp

@@ -226,7 +226,7 @@ TEST_F(RuleFeatureSetTest, interleavedDescendantSibling5)

InvalidationLists invalidationLists;

collectInvalidationSetsForClass(invalidationLists, "l");

expectNoInvalidation(invalidationLists.descendants);

- expectSiblingDescendantInvalidation(std::numeric_limits<unsigned>::max(), "n", "p", invalidationLists.siblings);

+ expectSiblingDescendantInvalidation(UINT_MAX, "n", "p", invalidationLists.siblings);

}

TEST_F(RuleFeatureSetTest, interleavedDescendantSibling6)

@@ -247,7 +247,7 @@ TEST_F(RuleFeatureSetTest, anySibling)

InvalidationLists invalidationLists;

collectInvalidationSetsForClass(invalidationLists, "q");

expectNoInvalidation(invalidationLists.descendants);

- expectSiblingDescendantInvalidation(std::numeric_limits<unsigned>::max(), "s", "t", invalidationLists.siblings);

+ expectSiblingDescendantInvalidation(UINT_MAX, "s", "t", invalidationLists.siblings);

}

TEST_F(RuleFeatureSetTest, any)