runtime/vm/debugger_api_impl_test.cc - Issue 1424703004: Getting rid of Isolate::current_zone() usage. Pass thread instead of isolate where it makes sense.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger_api_impl_test.cc

Issue 1424703004: Getting rid of Isolate::current_zone() usage. Pass thread instead of isolate where it makes sense. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Fix build Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger_api_impl_test.cc

diff --git a/runtime/vm/debugger_api_impl_test.cc b/runtime/vm/debugger_api_impl_test.cc

index ca260f2eedfd04edfd221264b6a26d1d7b5e5086..80b287941e5b1dd5731da30319e57698ceef5144 100644

--- a/runtime/vm/debugger_api_impl_test.cc

+++ b/runtime/vm/debugger_api_impl_test.cc

@@ -2138,8 +2138,8 @@ TEST_CASE(Debug_GetSupertype) {

"int main() {\n"

"}\n";

- Isolate* isolate = Isolate::Current();

- Zone* zone = isolate->current_zone();

+ Zone* zone = thread->zone();

LoadScript(kScriptChars);

ASSERT(script_lib != NULL);

ASSERT(Dart_IsLibrary(script_lib));

« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/isolate.h » ('j') | no next file with comments »