Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: runtime/vm/isolate.h

Issue 1424703004: Getting rid of Isolate::current_zone() usage. Pass thread instead of isolate where it makes sense. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Fix build Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/debugger_api_impl_test.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index 692351b884d5412f85b9ca289feace2976e90caa..0e7a224b2f22584f47b4c5d4f50fdeed9ccb7247 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -655,17 +655,6 @@ class Isolate : public BaseIsolate {
// Handle service messages until we are told to resume execution.
void PauseEventHandler();
- // DEPRECATED: Use Thread's methods instead. During migration, these default
- // to using the mutator thread (which must also be the current thread).
- Zone* current_zone() const {
- ASSERT(Thread::Current() == mutator_thread_);
- return mutator_thread_->zone();
- }
- void set_current_zone(Zone* zone) {
- ASSERT(Thread::Current() == mutator_thread_);
- mutator_thread_->set_zone(zone);
- }
-
bool is_service_isolate() const { return is_service_isolate_; }
static void KillAllIsolates(LibMsgId msg_id);
@@ -729,6 +718,13 @@ class Isolate : public BaseIsolate {
bool IsIsolateOf(Thread* thread);
#endif // DEBUG
+ // DEPRECATED: Use Thread's methods instead. During migration, these default
+ // to using the mutator thread (which must also be the current thread).
+ Zone* current_zone() const {
+ ASSERT(Thread::Current() == mutator_thread_);
+ return mutator_thread_->zone();
+ }
+
// Accessed from generated code:
uword stack_limit_;
StoreBuffer* store_buffer_;
« no previous file with comments | « runtime/vm/debugger_api_impl_test.cc ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698