Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1424703004: Getting rid of Isolate::current_zone() usage. Pass thread instead of isolate where it makes sense. (Closed)

Created:
5 years, 1 month ago by srdjan
Modified:
5 years, 1 month ago
Reviewers:
Cutch, hausner
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Getting rid of Isolate::current_zone() usage. Pass thread instead of isolate where it makes sense. BUG= R=hausner@google.com, johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/cd98aff66512862cf6716581d42aa7336b91fb45

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Cleanup #

Patch Set 4 : Synced #

Patch Set 5 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -255 lines) Patch
M runtime/lib/isolate.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M runtime/lib/vmservice.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/debugger.h View 1 2 3 2 chunks +3 lines, -5 lines 0 comments Download
M runtime/vm/debugger.cc View 1 2 17 chunks +51 lines, -45 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/isolate.h View 1 2 3 2 chunks +7 lines, -11 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 3 5 chunks +10 lines, -7 lines 0 comments Download
M runtime/vm/profiler_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/profiler_service.cc View 7 chunks +14 lines, -12 lines 0 comments Download
M runtime/vm/profiler_test.cc View 36 chunks +37 lines, -36 lines 0 comments Download
M runtime/vm/service.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 78 chunks +127 lines, -125 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 1 month ago (2015-10-26 21:29:16 UTC) #2
Cutch
profiler and service changes lgtm
5 years, 1 month ago (2015-10-26 21:36:54 UTC) #3
hausner
Rest LGTM as well.
5 years, 1 month ago (2015-10-26 21:44:26 UTC) #4
srdjan
5 years, 1 month ago (2015-10-26 22:33:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
cd98aff66512862cf6716581d42aa7336b91fb45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698