Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 1424703002: Revert of Assume that ReportFailedAccessCheck always schedules an exception. (Closed)

Created:
5 years, 1 month ago by Michael Achenbach
Modified:
5 years, 1 month ago
Reviewers:
neis, Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Assume that ReportFailedAccessCheck always schedules an exception. (patchset #1 id:1 of https://codereview.chromium.org/1420413002/ ) Reason for revert: [Sheriff] Crashes in layout tests: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/2539 # # Fatal error in , line 0 # unreachable code # Original issue's description: > Assume that ReportFailedAccessCheck always schedules an exception. > > R=verwaest@chromium.org > BUG= > > Committed: https://crrev.com/effe76ad25c23bfd8be447930bd5d5126b1c9096 > Cr-Commit-Position: refs/heads/master@{#31560} TBR=verwaest@chromium.org,neis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/e6c99b8c6f1ec597fe0a76222b835aeb0da53141 Cr-Commit-Position: refs/heads/master@{#31571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M src/builtins.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects.cc View 11 chunks +13 lines, -10 lines 0 comments Download
M src/runtime/runtime-classes.cc View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Assume that ReportFailedAccessCheck always schedules an exception.
5 years, 1 month ago (2015-10-26 14:53:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424703002/1
5 years, 1 month ago (2015-10-26 14:53:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 14:54:13 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 14:54:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6c99b8c6f1ec597fe0a76222b835aeb0da53141
Cr-Commit-Position: refs/heads/master@{#31571}

Powered by Google App Engine
This is Rietveld 408576698