src/builtins.cc - Issue 1424703002: Revert of Assume that ReportFailedAccessCheck always schedules an exception.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 1424703002: Revert of Assume that ReportFailedAccessCheck always schedules an exception. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index 4bde68cb03f1b5c3a224cef562b39907e3bcd818..1ed2fd125315eea8ca4af113cab5a668ad25cb3c 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -1712,7 +1712,6 @@

if (!isolate->MayAccess(handle(isolate->context()), js_receiver)) {

isolate->ReportFailedAccessCheck(js_receiver);

RETURN_EXCEPTION_IF_SCHEDULED_EXCEPTION(isolate, Object);

- UNREACHABLE();

}

« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »