Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: PRESUBMIT.py

Issue 14247012: Add support for parallel presubmit unit testing. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: fix nits Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | presubmit_canned_checks.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 15ac71781a12a8a1dd8cd122dca979bafec77d4e..a1e1c08686277d0a6d976573e5052b7e58fa334a 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -23,21 +23,21 @@ def CommonChecks(input_api, output_api, tests_to_black_list):
'R0401', # Cyclic import
'W0613', # Unused argument
]
- results.extend(input_api.canned_checks.RunPylint(
- input_api,
- output_api,
- white_list=[r'.*\.py$'],
- black_list=black_list,
- disabled_warnings=disabled_warnings))
-
- # TODO(maruel): Make sure at least one file is modified first.
- # TODO(maruel): If only tests are modified, only run them.
- results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
- input_api,
- output_api,
- 'tests',
- whitelist=[r'.*test\.py$'],
- blacklist=tests_to_black_list))
+ results.extend(input_api.RunTests(
+ input_api.canned_checks.GetPylint(
+ input_api,
+ output_api,
+ white_list=[r'.*\.py$'],
+ black_list=black_list,
+ disabled_warnings=disabled_warnings) +
+ # TODO(maruel): Make sure at least one file is modified first.
+ # TODO(maruel): If only tests are modified, only run them.
+ input_api.canned_checks.GetUnitTestsInDirectory(
+ input_api,
+ output_api,
+ 'tests',
+ whitelist=[r'.*test\.py$'],
+ blacklist=tests_to_black_list)))
return results
« no previous file with comments | « no previous file | presubmit_canned_checks.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698