| OLD | NEW | 
|---|
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be | 
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. | 
| 4 | 4 | 
| 5 """Top-level presubmit script for depot tools. | 5 """Top-level presubmit script for depot tools. | 
| 6 | 6 | 
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for | 
| 8 details on the presubmit API built into depot_tools. | 8 details on the presubmit API built into depot_tools. | 
| 9 """ | 9 """ | 
| 10 | 10 | 
| 11 | 11 | 
| 12 def CommonChecks(input_api, output_api, tests_to_black_list): | 12 def CommonChecks(input_api, output_api, tests_to_black_list): | 
| 13   results = [] | 13   results = [] | 
| 14   results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) | 14   results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) | 
| 15   black_list = list(input_api.DEFAULT_BLACK_LIST) + [ | 15   black_list = list(input_api.DEFAULT_BLACK_LIST) + [ | 
| 16       r'^cpplint\.py$', | 16       r'^cpplint\.py$', | 
| 17       r'^cpplint_chromium\.py$', | 17       r'^cpplint_chromium\.py$', | 
| 18       r'^python_bin[\/\\].+', | 18       r'^python_bin[\/\\].+', | 
| 19       r'^site-packages-py[0-9]\.[0-9][\/\\].+', | 19       r'^site-packages-py[0-9]\.[0-9][\/\\].+', | 
| 20       r'^svn_bin[\/\\].+', | 20       r'^svn_bin[\/\\].+', | 
| 21       r'^testing_support[\/\\]_rietveld[\/\\].+'] | 21       r'^testing_support[\/\\]_rietveld[\/\\].+'] | 
| 22   disabled_warnings = [ | 22   disabled_warnings = [ | 
| 23     'R0401',  # Cyclic import | 23     'R0401',  # Cyclic import | 
| 24     'W0613',  # Unused argument | 24     'W0613',  # Unused argument | 
| 25   ] | 25   ] | 
| 26   results.extend(input_api.canned_checks.RunPylint( | 26   results.extend(input_api.RunTests( | 
| 27       input_api, | 27       input_api.canned_checks.GetPylint( | 
| 28       output_api, | 28           input_api, | 
| 29       white_list=[r'.*\.py$'], | 29           output_api, | 
| 30       black_list=black_list, | 30           white_list=[r'.*\.py$'], | 
| 31       disabled_warnings=disabled_warnings)) | 31           black_list=black_list, | 
| 32 | 32           disabled_warnings=disabled_warnings) + | 
| 33   # TODO(maruel): Make sure at least one file is modified first. | 33       # TODO(maruel): Make sure at least one file is modified first. | 
| 34   # TODO(maruel): If only tests are modified, only run them. | 34       # TODO(maruel): If only tests are modified, only run them. | 
| 35   results.extend(input_api.canned_checks.RunUnitTestsInDirectory( | 35       input_api.canned_checks.GetUnitTestsInDirectory( | 
| 36       input_api, | 36           input_api, | 
| 37       output_api, | 37           output_api, | 
| 38       'tests', | 38           'tests', | 
| 39       whitelist=[r'.*test\.py$'], | 39           whitelist=[r'.*test\.py$'], | 
| 40       blacklist=tests_to_black_list)) | 40           blacklist=tests_to_black_list))) | 
| 41   return results | 41   return results | 
| 42 | 42 | 
| 43 | 43 | 
| 44 def RunGitClTests(input_api, output_api): | 44 def RunGitClTests(input_api, output_api): | 
| 45   """Run all the shells scripts in the directory test. | 45   """Run all the shells scripts in the directory test. | 
| 46   """ | 46   """ | 
| 47   if input_api.platform == 'win32': | 47   if input_api.platform == 'win32': | 
| 48     # Skip for now as long as the test scripts are bash scripts. | 48     # Skip for now as long as the test scripts are bash scripts. | 
| 49     return [] | 49     return [] | 
| 50 | 50 | 
| (...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after  Loading... | 
| 102 | 102 | 
| 103 | 103 | 
| 104 def CheckChangeOnCommit(input_api, output_api): | 104 def CheckChangeOnCommit(input_api, output_api): | 
| 105   output = [] | 105   output = [] | 
| 106   output.extend(CommonChecks(input_api, output_api, [])) | 106   output.extend(CommonChecks(input_api, output_api, [])) | 
| 107   output.extend(input_api.canned_checks.CheckDoNotSubmit( | 107   output.extend(input_api.canned_checks.CheckDoNotSubmit( | 
| 108       input_api, | 108       input_api, | 
| 109       output_api)) | 109       output_api)) | 
| 110   output.extend(RunGitClTests(input_api, output_api)) | 110   output.extend(RunGitClTests(input_api, output_api)) | 
| 111   return output | 111   return output | 
| OLD | NEW | 
|---|