Source/core/platform/network/chromium/ResourceHandleInternal.h - Issue 14246006: Implementing timeout support for XHR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/network/chromium/ResourceHandleInternal.h

Issue 14246006: Implementing timeout support for XHR (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@timeoutResourceHandle

Patch Set: Adressing eview comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/platform/network/chromium/ResourceHandle.cpp ('K') | « Source/core/platform/network/chromium/ResourceHandle.cpp ('k') | Source/core/xml/XMLHttpRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/network/chromium/ResourceHandleInternal.h

diff --git a/Source/core/platform/network/chromium/ResourceHandleInternal.h b/Source/core/platform/network/chromium/ResourceHandleInternal.h

index 6a915516b15dff118f2e0c453dd39cdc7b0a542b..32a951cd8633f8f265453fa28e412fbdf6b50f49 100644

--- a/Source/core/platform/network/chromium/ResourceHandleInternal.h

+++ b/Source/core/platform/network/chromium/ResourceHandleInternal.h

@@ -32,6 +32,7 @@

#define ResourceHandleInternal_h

#include "ResourceRequest.h"

+#include "Timer.h"

#include <public/WebCommon.h>

#include <public/WebURLLoader.h>

#include <public/WebURLLoaderClient.h>

@@ -85,6 +86,8 @@ public:

static ResourceHandleInternal* FromResourceHandle(ResourceHandle*);

+ void timerFired(Timer<ResourceHandleInternal>*);

abarth-chromium 2013/04/19 16:29:48 Looks like you missed my comment about making this

private:

RefPtr<NetworkingContext> m_context;

ResourceRequest m_request;

@@ -95,6 +98,8 @@ private:

// Used for sanity checking to make sure we don't experience illegal state

// transitions.

ConnectionState m_state;

+ Timer<ResourceHandleInternal> m_timeoutTimer;

};

} // namespace WebCore