Source/core/platform/network/chromium/ResourceHandleInternal.h - Issue 14246006: Implementing timeout support for XHR

Side by Side Diff: Source/core/platform/network/chromium/ResourceHandleInternal.h

Issue 14246006: Implementing timeout support for XHR (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@timeoutResourceHandle

Patch Set: Adressing eview comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/core/platform/network/chromium/ResourceHandle.cpp ('K') | « Source/core/platform/network/chromium/ResourceHandle.cpp ('k') | Source/core/xml/XMLHttpRequest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 14 matching lines...) Expand all Loading...
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY	25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY

26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT	26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE	27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

29 */	29 */

30	30

31 #ifndef ResourceHandleInternal_h	31 #ifndef ResourceHandleInternal_h

32 #define ResourceHandleInternal_h	32 #define ResourceHandleInternal_h

33	33

34 #include "ResourceRequest.h"	34 #include "ResourceRequest.h"

	35 #include "Timer.h"

35 #include <public/WebCommon.h>	36 #include <public/WebCommon.h>

36 #include <public/WebURLLoader.h>	37 #include <public/WebURLLoader.h>

37 #include <public/WebURLLoaderClient.h>	38 #include <public/WebURLLoaderClient.h>

38 #include <public/WebURLRequest.h>	39 #include <public/WebURLRequest.h>

39	40

40 namespace WebCore {	41 namespace WebCore {

41	42

42 class NetworkingContext;	43 class NetworkingContext;

43 class ResourceHandle;	44 class ResourceHandle;

44 class ResourceHandleClient;	45 class ResourceHandleClient;

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
78	79

79 void setOwner(ResourceHandle* owner) { m_owner = owner; }	80 void setOwner(ResourceHandle* owner) { m_owner = owner; }

80 ResourceRequest& request() { return m_request; }	81 ResourceRequest& request() { return m_request; }

81 ResourceHandleClient* client() const { return m_client; }	82 ResourceHandleClient* client() const { return m_client; }

82 void setClient(ResourceHandleClient* client) { m_client = client; }	83 void setClient(ResourceHandleClient* client) { m_client = client; }

83 WebKit::WebURLLoader* loader() const { return m_loader.get(); }	84 WebKit::WebURLLoader* loader() const { return m_loader.get(); }

84 NetworkingContext* context() const { return m_context.get(); }	85 NetworkingContext* context() const { return m_context.get(); }

85	86

86 static ResourceHandleInternal* FromResourceHandle(ResourceHandle*);	87 static ResourceHandleInternal* FromResourceHandle(ResourceHandle*);

87	88

	89 void timerFired(Timer<ResourceHandleInternal>*);
	abarth-chromium 2013/04/19 16:29:48 Looks like you missed my comment about making this Looks like you missed my comment about making this function private.
	90

88 private:	91 private:

89 RefPtr<NetworkingContext> m_context;	92 RefPtr<NetworkingContext> m_context;

90 ResourceRequest m_request;	93 ResourceRequest m_request;

91 ResourceHandle* m_owner;	94 ResourceHandle* m_owner;

92 ResourceHandleClient* m_client;	95 ResourceHandleClient* m_client;

93 OwnPtr<WebKit::WebURLLoader> m_loader;	96 OwnPtr<WebKit::WebURLLoader> m_loader;

94	97

95 // Used for sanity checking to make sure we don't experience illegal state	98 // Used for sanity checking to make sure we don't experience illegal state

96 // transitions.	99 // transitions.

97 ConnectionState m_state;	100 ConnectionState m_state;

	101

	102 Timer<ResourceHandleInternal> m_timeoutTimer;

98 };	103 };

99	104

100 } // namespace WebCore	105 } // namespace WebCore

101	106

102 #endif	107 #endif

OLD	NEW