Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 1424593003: Revert of mac: In static library builds, link against a static libc++.a (Closed)

Created:
5 years, 2 months ago by DaleCurtis
Modified:
5 years, 2 months ago
Reviewers:
Mark Mentovai, Nico
CC:
chromium-reviews, eugenis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: In static library builds, link against a static libc++.a (patchset #4 id:60001 of https://codereview.chromium.org/1413863003/ ) Reason for revert: Failed lots of bots still :( Some in runhooks with: Using overrides found in /Users/chrome-bot/.gyp/include.gypi gyp: name 'asan' is not defined while evaluating condition '0==0 and component=="static_library" and asan==0' in /b/build/slave/Mac/build/src/third_party/pdfium/pdfium.gyp http://build.chromium.org/p/chromium/buildstatus?builder=Mac&number=8563 Some with compile errors: FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang -Wl,-search_paths_first ... ld: library not found for -lc++ http://build.chromium.org/p/chromium.memory/buildstatus?builder=Mac%20ASan%2064%20Builder&number=27065 Original issue's description: > mac: In static library builds, link against a static libc++.a > > To achieve this, just add a -Lthird_party/libc++-static flag to the link line, > and add a postbuild that checks that Chromium Framework depends on neither > libstdc++.dylib nor libc++.dylib Use the existing verify_order postbuild > for this, and let it not run in component builds (since what it checks for > isn't interesting in that config, and we do depend on system libc++ in > component builds). > > This change is small but subtle, see thread > "[chromium-dev] Intent to implement: Statically linking libc++ for Chrome/Mac" > and the document linked from comment 14 on the bug for details. > > Ideally, this has no observable behavior change. If it looks like this > breaks tests somewhere, especially on 10.6, please revert. (The bots > like it, and the things I tried on 10.6 worked too, though.) > > BUG=400091 > R=mark@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/494270d01189f8b4b2b4ebd501fd980833489729 > > Committed: https://chromium.googlesource.com/chromium/src/+/0f56cff872068cef226e7ad3f9701eb41d4eb2f5 TBR=mark@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=400091 Committed: https://crrev.com/73e401c9ac64cce0bde4028783f19e2e802137dc Cr-Commit-Position: refs/heads/master@{#355854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -54 lines) Patch
M .gitignore View 1 chunk +1 line, -1 line 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 2 chunks +15 lines, -30 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/mac/verify_order View 2 chunks +0 lines, -16 lines 0 comments Download
M third_party/libc++-static/build.sh View 1 chunk +4 lines, -4 lines 0 comments Download
A third_party/libc++-static/libc++-static.a.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/libc++-static/libc++.a.sha1 View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
DaleCurtis
Created Revert of mac: In static library builds, link against a static libc++.a
5 years, 2 months ago (2015-10-23 19:19:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1424593003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1424593003/1
5 years, 2 months ago (2015-10-23 19:20:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 19:21:13 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 19:22:10 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73e401c9ac64cce0bde4028783f19e2e802137dc
Cr-Commit-Position: refs/heads/master@{#355854}

Powered by Google App Engine
This is Rietveld 408576698