SkRecord refactor: fill bounds array instead of BBH directly

SkRecord refactor: fill bounds array instead of BBH directly

This should be a strict refactor, just pulling out the bounds array.
(It's the rescued nice parts of a dead-end CL targeting skia:4492.)

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/40732b34a1bf94eb44ee4b2327eece8d97735f11

[mtklein_C, 2015-10-23 17:58:50]

Description was changed from

==========
SkRecord refactor: fill bounds array instead of BBH directly

BUG=skia:
==========

to

==========
SkRecord refactor: fill bounds array instead of BBH directly

This should be a strict refactor, just pulling out the bounds array.
(It's the rescued nice parts of a dead-end CL targeting skia:4492.)

BUG=skia:
==========

[mtklein_C, 2015-10-23 17:59:01]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 17:59:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424553002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424553002/1

[mtklein_C, 2015-10-23 18:00:42]

mtklein@chromium.org changed reviewers:
+ robertphillips@google.com

[mtklein_C, 2015-10-23 18:00:42]

If nothing else I like how this changes the unit tests.

[commit-bot: I haz the power, 2015-10-23 18:18:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 18:18:49]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-10-23 19:07:07]

https://codereview.chromium.org/1424553002/diff/1/src/core/SkRecordDraw.h
File src/core/SkRecordDraw.h (right):

https://codereview.chromium.org/1424553002/diff/1/src/core/SkRecordDraw.h#new...
src/core/SkRecordDraw.h:22: 
Maybe: This code gathers information about saveLayers and stores it for later
use (e.g., layer hoisting). The gathered information is sufficient to determine
where the saveLayer will land and which ops in the picture it represents.

?

[mtklein_C, 2015-10-23 19:09:49]

https://codereview.chromium.org/1424553002/diff/1/src/core/SkRecordDraw.h
File src/core/SkRecordDraw.h (right):

https://codereview.chromium.org/1424553002/diff/1/src/core/SkRecordDraw.h#new...
src/core/SkRecordDraw.h:22: 
On 2015/10/23 19:07:07, robertphillips wrote:
> Maybe: This code gathers information about saveLayers and stores it for later
> use (e.g., layer hoisting). The gathered information is sufficient to
determine
> where the saveLayer will land and which ops in the picture it represents.
> 
> ?

Done.

[mtklein_C, 2015-10-23 19:09:55]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 19:10:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424553002/40001

[mtklein_C, 2015-10-23 19:11:38]

PS2 puts cleanUp() back.  (That didn't help my problems in the next CL.)

[commit-bot: I haz the power, 2015-10-23 19:25:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 19:25:11]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2015-10-23 21:12:33]

lgtm

[mtklein, 2015-10-24 14:44:48]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-10-24 14:44:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1424553002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1424553002/40001

[commit-bot: I haz the power, 2015-10-24 14:45:51]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/40732b34a1bf94eb44ee4b2327eece8d97735f11