Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: src/compiler/js-native-context-specialization.cc

Issue 1424533002: [turbofan] Properly deal with empty access info list for JSStoreNamed. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-native-context-specialization.cc
diff --git a/src/compiler/js-native-context-specialization.cc b/src/compiler/js-native-context-specialization.cc
index 907f915695a7f31fd5563fe6ad572181cab0a19d..71597d4683ab8e9d0284d8865f1527843f0ff245 100644
--- a/src/compiler/js-native-context-specialization.cc
+++ b/src/compiler/js-native-context-specialization.cc
@@ -709,7 +709,9 @@ Reduction JSNativeContextSpecialization::ReduceJSStoreNamed(Node* node) {
if (!ComputePropertyAccessInfos(receiver_maps, name, kStore, &access_infos)) {
return NoChange();
}
- DCHECK(!access_infos.empty());
+
+ // Nothing to do if we have no non-deprecated maps.
+ if (access_infos.empty()) return NoChange();
// The final states for every polymorphic branch. We join them with
// Merge+EffectPhi at the bottom.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698