Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: src/compiler/js-native-context-specialization.cc

Issue 1424533002: [turbofan] Properly deal with empty access info list for JSStoreNamed. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-native-context-specialization.h" 5 #include "src/compiler/js-native-context-specialization.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/compilation-dependencies.h" 8 #include "src/compilation-dependencies.h"
9 #include "src/compiler/access-builder.h" 9 #include "src/compiler/access-builder.h"
10 #include "src/compiler/js-graph.h" 10 #include "src/compiler/js-graph.h"
(...skipping 691 matching lines...) Expand 10 before | Expand all | Expand 10 after
702 if (!p.feedback().IsValid()) return NoChange(); 702 if (!p.feedback().IsValid()) return NoChange();
703 StoreICNexus nexus(p.feedback().vector(), p.feedback().slot()); 703 StoreICNexus nexus(p.feedback().vector(), p.feedback().slot());
704 if (nexus.ExtractMaps(&receiver_maps) == 0) return NoChange(); 704 if (nexus.ExtractMaps(&receiver_maps) == 0) return NoChange();
705 DCHECK_LT(0, receiver_maps.length()); 705 DCHECK_LT(0, receiver_maps.length());
706 706
707 // Compute property access infos for the receiver maps. 707 // Compute property access infos for the receiver maps.
708 ZoneVector<PropertyAccessInfo> access_infos(zone()); 708 ZoneVector<PropertyAccessInfo> access_infos(zone());
709 if (!ComputePropertyAccessInfos(receiver_maps, name, kStore, &access_infos)) { 709 if (!ComputePropertyAccessInfos(receiver_maps, name, kStore, &access_infos)) {
710 return NoChange(); 710 return NoChange();
711 } 711 }
712 DCHECK(!access_infos.empty()); 712
713 // Nothing to do if we have no non-deprecated maps.
714 if (access_infos.empty()) return NoChange();
713 715
714 // The final states for every polymorphic branch. We join them with 716 // The final states for every polymorphic branch. We join them with
715 // Merge+EffectPhi at the bottom. 717 // Merge+EffectPhi at the bottom.
716 ZoneVector<Node*> effects(zone()); 718 ZoneVector<Node*> effects(zone());
717 ZoneVector<Node*> controls(zone()); 719 ZoneVector<Node*> controls(zone());
718 720
719 // The list of "exiting" controls, which currently go to a single deoptimize. 721 // The list of "exiting" controls, which currently go to a single deoptimize.
720 // TODO(bmeurer): Consider using an IC as fallback. 722 // TODO(bmeurer): Consider using an IC as fallback.
721 Node* const exit_effect = effect; 723 Node* const exit_effect = effect;
722 ZoneVector<Node*> exit_controls(zone()); 724 ZoneVector<Node*> exit_controls(zone());
(...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after
979 } 981 }
980 982
981 983
982 SimplifiedOperatorBuilder* JSNativeContextSpecialization::simplified() const { 984 SimplifiedOperatorBuilder* JSNativeContextSpecialization::simplified() const {
983 return jsgraph()->simplified(); 985 return jsgraph()->simplified();
984 } 986 }
985 987
986 } // namespace compiler 988 } // namespace compiler
987 } // namespace internal 989 } // namespace internal
988 } // namespace v8 990 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698