Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 1424313003: element.scrollIntoView only scrolls the layout viewport (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h
index 61509f857388094fc55b179128c6d19bd2db9971..4790b81f77d36d188fc8356d53aa83af33446f2a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h
@@ -425,7 +425,7 @@ public:
void scrollToOffset(const DoubleSize&, ScrollBehavior = ScrollBehaviorInstant);
void scrollByRecursively(const DoubleSize& delta, ScrollOffsetClamping = ScrollOffsetUnclamped);
- void scrollRectToVisible(const LayoutRect&, const ScrollAlignment& alignX, const ScrollAlignment& alignY, ScrollType = ProgrammaticScroll);
+ void scrollRectToVisible(const LayoutRect&, const ScrollAlignment& alignX, const ScrollAlignment& alignY, ScrollType = ProgrammaticScroll, bool scrollVisualViewport = true);
bokan 2015/10/30 16:08:55 I think this param should be called something like
ymalik 2015/11/01 00:02:24 Done.
LayoutRectOutsets marginBoxOutsets() const override { return m_marginBoxOutsets; }
LayoutUnit marginTop() const override { return m_marginBoxOutsets.top(); }

Powered by Google App Engine
This is Rietveld 408576698