element.scrollIntoView only scrolls the layout viewport

third_party/WebKit/Source/core/layout/LayoutBox.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 407 matching lines @@
     virtual LayoutUnit scrollTop() const;
     virtual LayoutUnit scrollWidth() const;
     virtual LayoutUnit scrollHeight() const;
     int pixelSnappedScrollWidth() const;
     int pixelSnappedScrollHeight() const;
     virtual void setScrollLeft(LayoutUnit);
     virtual void setScrollTop(LayoutUnit);
 
     void scrollToOffset(const DoubleSize&, ScrollBehavior = ScrollBehaviorInstant);
     void scrollByRecursively(const DoubleSize& delta, ScrollOffsetClamping = ScrollOffsetUnclamped);
-    void scrollRectToVisible(const LayoutRect&, const ScrollAlignment& alignX, const ScrollAlignment& alignY, ScrollType = ProgrammaticScroll);
+    void scrollRectToVisible(const LayoutRect&, const ScrollAlignment& alignX, const ScrollAlignment& alignY, ScrollType = ProgrammaticScroll, bool scrollVisualViewport = true);

[bokan, 2015/10/30 16:08:55]

I think this param should be called something like makeVisibleInVisualViewport
since scrollVisualViewport could plausibly be interpreted that it'll still
scroll the layout viewport such that the rect is visible in the visual viewport.
Please also add a comment describing what this param will do.

[ymalik, 2015/11/01 00:02:24]

Done.

 
     LayoutRectOutsets marginBoxOutsets() const override { return m_marginBoxOutsets; }
     LayoutUnit marginTop() const override { return m_marginBoxOutsets.top(); }
     LayoutUnit marginBottom() const override { return m_marginBoxOutsets.bottom(); }
     LayoutUnit marginLeft() const override { return m_marginBoxOutsets.left(); }
     LayoutUnit marginRight() const override { return m_marginBoxOutsets.right(); }
     void setMarginTop(LayoutUnit margin) { m_marginBoxOutsets.setTop(margin); }
     void setMarginBottom(LayoutUnit margin) { m_marginBoxOutsets.setBottom(margin); }
     void setMarginLeft(LayoutUnit margin) { m_marginBoxOutsets.setLeft(margin); }
     void setMarginRight(LayoutUnit margin) { m_marginBoxOutsets.setRight(margin); }
@@ skipping 616 matching lines @@
         if (UNLIKELY(inlineBoxWrapper() != nullptr))
             deleteLineBoxWrapper();
     }
 
     ensureRareData().m_inlineBoxWrapper = boxWrapper;
 }
 
 } // namespace blink
 
 #endif // LayoutBox_h