content/renderer/render_frame_impl.cc - Issue 1424263003: Reland "Use resource throttle to implement shouldOverrideUrlLoading, core change"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1424263003: Reland "Use resource throttle to implement shouldOverrideUrlLoading, core change" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing instrumentation tests (connected to userGesture and isMainFrame) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java ('K') | « content/public/renderer/content_renderer_client.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index c000e4b1588c415812b3d801c4360ca1d0074e85..4decc9de93a3598efe298e49059374be2f850060 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -4390,18 +4390,6 @@ WebNavigationPolicy RenderFrameImpl::decidePolicyForNavigation(

(pending_navigation_params_ &&

!pending_navigation_params_->request_params.redirects.empty());

-#ifdef OS_ANDROID

- // The handlenavigation API is deprecated and will be removed once

- // crbug.com/325351 is resolved.

- if (info.urlRequest.url() != GURL(kSwappedOutURL) &&

- GetContentClient()->renderer()->HandleNavigation(

- this, is_content_initiated, render_view_->opener_id_, frame_,

- info.urlRequest, info.navigationType, info.defaultPolicy,

- is_redirect)) {

- return blink::WebNavigationPolicyIgnore;

- }

-#endif

Referrer referrer(

RenderViewImpl::GetReferrerFromRequest(frame_, info.urlRequest));