content/public/renderer/content_renderer_client.cc - Issue 1424263003: Reland "Use resource throttle to implement shouldOverrideUrlLoading, core change"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/content_renderer_client.cc

Issue 1424263003: Reland "Use resource throttle to implement shouldOverrideUrlLoading, core change" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing instrumentation tests (connected to userGesture and isMainFrame) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java ('K') | « content/public/renderer/content_renderer_client.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/renderer/content_renderer_client.cc

diff --git a/content/public/renderer/content_renderer_client.cc b/content/public/renderer/content_renderer_client.cc

index 3d0316f068f21d1a057a6af21bc95887aa0e20e6..32004d1c37e7a459eb20cb8361c7e876e5e672e2 100644

--- a/content/public/renderer/content_renderer_client.cc

+++ b/content/public/renderer/content_renderer_client.cc

@@ -98,20 +98,6 @@ bool ContentRendererClient::AllowPopup() {

return false;

}

-#ifdef OS_ANDROID

-bool ContentRendererClient::HandleNavigation(

- RenderFrame* render_frame,

- bool is_content_initiated,

- int opener_id,

- blink::WebFrame* frame,

- const blink::WebURLRequest& request,

- blink::WebNavigationType type,

- blink::WebNavigationPolicy default_policy,

- bool is_redirect) {

- return false;

-#endif

bool ContentRendererClient::ShouldFork(blink::WebLocalFrame* frame,

const GURL& url,

const std::string& http_method,