Fix another corner-case behavior of Object::SetSuperProperty.

src/objects.cc

Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 7422aec4e6603ddbbf52a3295a9fea13e8da9b6b..fa3ce5307c4d2da7d65563e8d14158020f8fa3c8 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -3766,11 +3766,11 @@ Maybe<bool> Object::SetSuperProperty(LookupIterator* it, Handle<Object> value,
 
       case LookupIterator::DATA: {
         PropertyDetails details = own_lookup.property_details();
-        if (details.IsConfigurable() || !details.IsReadOnly()) {
-          return JSObject::DefineOwnPropertyIgnoreAttributes(
-              &own_lookup, value, details.attributes(), should_throw);
+        if (details.IsReadOnly()) {
+          return WriteToReadOnlyProperty(&own_lookup, value, should_throw);
         }
-        return WriteToReadOnlyProperty(&own_lookup, value, should_throw);
+        return JSObject::DefineOwnPropertyIgnoreAttributes(
+            &own_lookup, value, details.attributes(), should_throw);

[Toon Verwaest, 2015/11/03 12:06:52]

Won't this just SetDataProperty(it, value, THROW_ON_ERROR)?

[neis, 2015/11/03 12:56:07]

Not THROW_ON_ERROR, but yeah, looks like this will always just call
SetDataProperty.  I simplified the code accordingly.  PTAL.

       }
 
       case LookupIterator::ACCESSOR: {