Fix another corner-case behavior of Object::SetSuperProperty.

src/objects.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/objects.h"
 
 #include <cmath>
 #include <iomanip>
 #include <sstream>
 
@@ skipping 3748 matching lines @@
                                                             should_throw);
         }
         break;
 
       case LookupIterator::INTEGER_INDEXED_EXOTIC:
         return RedefineIncompatibleProperty(it->isolate(), it->GetName(), value,
                                             should_throw);
 
       case LookupIterator::DATA: {
         PropertyDetails details = own_lookup.property_details();
-        if (details.IsConfigurable() || !details.IsReadOnly()) {
-          return JSObject::DefineOwnPropertyIgnoreAttributes(
-              &own_lookup, value, details.attributes(), should_throw);
+        if (details.IsReadOnly()) {
+          return WriteToReadOnlyProperty(&own_lookup, value, should_throw);
         }
-        return WriteToReadOnlyProperty(&own_lookup, value, should_throw);
+        return JSObject::DefineOwnPropertyIgnoreAttributes(
+            &own_lookup, value, details.attributes(), should_throw);

[Toon Verwaest, 2015/11/03 12:06:52]

Won't this just SetDataProperty(it, value, THROW_ON_ERROR)?

[neis, 2015/11/03 12:56:07]

Not THROW_ON_ERROR, but yeah, looks like this will always just call
SetDataProperty.  I simplified the code accordingly.  PTAL.

       }
 
       case LookupIterator::ACCESSOR: {
         return RedefineIncompatibleProperty(it->isolate(), it->GetName(), value,
                                             should_throw);
       }
 
       case LookupIterator::INTERCEPTOR:
       case LookupIterator::JSPROXY: {
         bool found = false;
@@ skipping 14225 matching lines @@
   if (cell->value() != *new_value) {
     cell->set_value(*new_value);
     Isolate* isolate = cell->GetIsolate();
     cell->dependent_code()->DeoptimizeDependentCodeGroup(
         isolate, DependentCode::kPropertyCellChangedGroup);
   }
 }
 
 }  // namespace internal
 }  // namespace v8