Issue 1424213005: win: Construct ExceptionHandlerServer() with its pipe argument (again)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1424213005: win: Construct ExceptionHandlerServer() with its pipe argument (again) (Closed)

Created:
5 years, 1 month ago by Mark Mentovai

Modified:
5 years, 1 month ago

Reviewers:
scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

win: Construct ExceptionHandlerServer() with its pipe argument (again) This re-lands 9d03d54d0ba1, which was partially un-done by an apparent bad rebase leading up to fc7d8b3a27e1. Committed: https://chromium.googlesource.com/crashpad/crashpad/+/06ad1945718ecc95a2c353ae5b002c126c2f61d1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -29 lines)			Patch
M	snapshot/win/exception_snapshot_win_test.cc	View	3 chunks	+7 lines, -11 lines	0 comments	Download
M	util/win/exception_handler_server.h	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	util/win/exception_handler_server.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	util/win/exception_handler_server_test.cc	View	2 chunks	+6 lines, -8 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

Committed patchset #1 (id:1) manually as 06ad1945718ecc95a2c353ae5b002c126c2f61d1 (presubmit successful).

5 years, 1 month ago (2015-10-29 22:19:43 UTC) #1

Mark Mentovai

TBR. This is exactly the same as what you already reviewed (minus main.cc). I have ...

5 years, 1 month ago (2015-10-29 22:20:52 UTC) #3

Message was sent while issue was closed.

lgtm