Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Unified Diff: util/win/exception_handler_server.h

Issue 1424213005: win: Construct ExceptionHandlerServer() with its pipe argument (again) (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/win/exception_snapshot_win_test.cc ('k') | util/win/exception_handler_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/exception_handler_server.h
diff --git a/util/win/exception_handler_server.h b/util/win/exception_handler_server.h
index 6928a6d9037b33f04e6794a8ce102cf211fb77d9..d1243406228e98b912d6b7699c7f1c2e2e7d2563 100644
--- a/util/win/exception_handler_server.h
+++ b/util/win/exception_handler_server.h
@@ -61,16 +61,18 @@ class ExceptionHandlerServer {
};
//! \brief Constructs the exception handling server.
- ExceptionHandlerServer();
+ //!
+ //! \param[in] pipe_name The name of the pipe to listen on. Must be of the
+ //! form "\\.\pipe\<some_name>".
+ explicit ExceptionHandlerServer(const std::string& pipe_name);
+
~ExceptionHandlerServer();
//! \brief Runs the exception-handling server.
//!
//! \param[in] delegate The interface to which the exceptions are delegated
//! when they are caught in Run(). Ownership is not transferred.
- //! \param[in] pipe_name The name of the pipe to listen on. Must be of the
- //! form "\\.\pipe\<some_name>".
- void Run(Delegate* delegate, const std::string& pipe_name);
+ void Run(Delegate* delegate);
//! \brief Stops the exception-handling server. Returns immediately. The
//! object must not be destroyed until Run() returns.
@@ -84,6 +86,7 @@ class ExceptionHandlerServer {
static void __stdcall OnNonCrashDumpEvent(void* ctx, BOOLEAN);
static void __stdcall OnProcessEnd(void* ctx, BOOLEAN);
+ std::string pipe_name_;
ScopedKernelHANDLE port_;
base::Lock clients_lock_;
« no previous file with comments | « snapshot/win/exception_snapshot_win_test.cc ('k') | util/win/exception_handler_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698