Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1424133002: Fix broken console evaluation in devtools when stopped at an async frame. (Closed)

Created:
5 years, 1 month ago by Jacob
Modified:
5 years, 1 month ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix broken console evaluation in devtools when stopped at an async frame. It appears that the Dart VM is now adding a local with invalid dart name :async_op in some cases when the call stack is async. This change filters out those variables from the list of locals. BUG= R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/9075efbb432a2e5da5b725c3331e05eedfebd795

Patch Set 1 #

Total comments: 1

Patch Set 2 : ptal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/src/native_DOMImplementation.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
5 years, 1 month ago (2015-10-27 22:12:15 UTC) #2
Alan Knight
lgtm, with nit https://codereview.chromium.org/1424133002/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/1424133002/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode269 tools/dom/src/native_DOMImplementation.dart:269: // Avoid being broken by bogus ...
5 years, 1 month ago (2015-10-27 22:20:08 UTC) #4
Jacob
5 years, 1 month ago (2015-10-28 22:00:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:10001) manually as
9075efbb432a2e5da5b725c3331e05eedfebd795 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698